Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1619433002: Always run the RunLoop in StartupHelper::ValidateCrx. (Closed)

Created:
4 years, 11 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always run the RunLoop in StartupHelper::ValidateCrx. This is safe because both success and fail paths post a quit-if-running task back to the UI thread. BUG=259861 Committed: https://crrev.com/6d85a4a2d8e1b1e7a0946d08aeebcb1fe4c015cd Cr-Commit-Position: refs/heads/master@{#370757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/startup_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Mistry (off Chromium)
4 years, 11 months ago (2016-01-21 03:11:13 UTC) #2
asargent_no_longer_on_chrome
lgtm, thanks for the patch!
4 years, 11 months ago (2016-01-21 18:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619433002/1
4 years, 11 months ago (2016-01-21 19:40:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 19:47:15 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:48:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d85a4a2d8e1b1e7a0946d08aeebcb1fe4c015cd
Cr-Commit-Position: refs/heads/master@{#370757}

Powered by Google App Engine
This is Rietveld 408576698