chrome/browser/extensions/startup_helper.cc - Issue 1619433002: Always run the RunLoop in StartupHelper::ValidateCrx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/startup_helper.cc

Issue 1619433002: Always run the RunLoop in StartupHelper::ValidateCrx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/startup_helper.cc

diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc

index 53cd444db03a60fcf600eb5fc329a278c497f853..4b5a94bf1827c7953b40c232ab0bad9184f0b2d4 100644

--- a/chrome/browser/extensions/startup_helper.cc

+++ b/chrome/browser/extensions/startup_helper.cc

@@ -181,8 +181,7 @@ bool StartupHelper::ValidateCrx(const base::CommandLine& cmd_line,

scoped_refptr<ValidateCrxHelper> helper(

new ValidateCrxHelper(file, temp_dir.path(), &run_loop));

helper->Start();

- if (!helper->finished())

- run_loop.Run();

+ run_loop.Run();

bool success = helper->success();

if (!success)

« no previous file with comments | « no previous file | no next file » | no next file with comments »