Create //ui/base/ime:text_input_base target.

Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail when a library has no source files
in them.

BUG=361137
Committed: https://crrev.com/8dd34a13c2228f86066da8ba3a22d02321ab6caa
Cr-Commit-Position: refs/heads/master@{#371744}

[kylechar, 2016-01-25 16:40:50]

Description was changed from

==========
Remove dep.

Remove dep from X11Window to X11EventSource.

BUG=
==========

to

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_base. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.

The new target only has header files with enum definitions. Two of the
files in the new target were no previously in any target.

BUG=
==========

[kylechar, 2016-01-25 20:59:42]

Description was changed from

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_base. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.

The new target only has header files with enum definitions. Two of the
files in the new target were no previously in any target.

BUG=
==========

to

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_base. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
This fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target.

BUG=361137
==========

[kylechar, 2016-01-25 21:00:17]

Patchset #3 (id:40001) has been deleted

[kylechar, 2016-01-25 21:00:21]

Patchset #2 (id:20001) has been deleted

[kylechar, 2016-01-25 21:51:07]

Description was changed from

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_base. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
This fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target.

BUG=361137
==========

to

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail to compile when a library has no
source files in them.

BUG=361137
==========

[kylechar, 2016-01-25 21:51:33]

Description was changed from

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail to compile when a library has no
source files in them.

BUG=361137
==========

to

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail when a library has no source files
in them.

BUG=361137
==========

[kylechar, 2016-01-25 21:52:52]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[kylechar, 2016-01-25 21:54:26]

Small change to allow ozone_platform_x11 to use X11Window (and fix some existing
dependency issues).

[sadrul, 2016-01-26 17:50:38]

Update the CL description to say 'text_input_type' (instead of
'text_input_base')

https://codereview.chromium.org/1619423003/diff/80001/ui/base/ime/BUILD.gn
File ui/base/ime/BUILD.gn (right):

https://codereview.chromium.org/1619423003/diff/80001/ui/base/ime/BUILD.gn#ne...
ui/base/ime/BUILD.gn:8: source_set("text_input_types") {
I think you want group() here, instead of source_set()

https://codereview.chromium.org/1619423003/diff/80001/ui/ozone/BUILD.gn
File ui/ozone/BUILD.gn (right):

https://codereview.chromium.org/1619423003/diff/80001/ui/ozone/BUILD.gn#newco...
ui/ozone/BUILD.gn:152: "//ui/platform_window",
Is this relevant for this CL?

[sadrul, 2016-01-26 17:51:40]

sadrul@chromium.org changed reviewers:
+ shuchen@chromium.org

[sadrul, 2016-01-26 17:51:40]

Looks good with the nits addressed. +shuchen@ for ui/base/ime/ owner review.

[kylechar, 2016-01-26 17:58:34]

https://codereview.chromium.org/1619423003/diff/80001/ui/base/ime/BUILD.gn
File ui/base/ime/BUILD.gn (right):

https://codereview.chromium.org/1619423003/diff/80001/ui/base/ime/BUILD.gn#ne...
ui/base/ime/BUILD.gn:8: source_set("text_input_types") {
On 2016/01/26 at 17:50:38, sadrul wrote:
> I think you want group() here, instead of source_set()

Discussed in person. Will leave it as source_set.

https://codereview.chromium.org/1619423003/diff/80001/ui/ozone/BUILD.gn
File ui/ozone/BUILD.gn (right):

https://codereview.chromium.org/1619423003/diff/80001/ui/ozone/BUILD.gn#newco...
ui/ozone/BUILD.gn:152: "//ui/platform_window",
On 2016/01/26 at 17:50:38, sadrul wrote:
> Is this relevant for this CL?

This is the reason for the other target/dep changes, so that this is no longer a
circular dependency. So it seems neater to wrap it up into this CL.

[spang, 2016-01-26 18:00:08]

spang@chromium.org changed reviewers:
+ spang@chromium.org

[spang, 2016-01-26 18:00:09]

https://codereview.chromium.org/1619423003/diff/80001/ui/base/ime/BUILD.gn
File ui/base/ime/BUILD.gn (right):

https://codereview.chromium.org/1619423003/diff/80001/ui/base/ime/BUILD.gn#ne...
ui/base/ime/BUILD.gn:8: source_set("text_input_types") {
On 2016/01/26 17:50:38, sadrul wrote:
> I think you want group() here, instead of source_set()

group() doesn't have have sources = [...]

I think it has to be static_library or source_set, but I'm not sure it matters
which. I cannot think of any difference with only headers in "sources".

[sadrul, 2016-01-26 18:02:28]

lgtm. Please wait for shuchen@'s approval for ui/base/ime

[Shu Chen, 2016-01-27 00:38:51]

lgtm

[kylechar, 2016-01-27 04:35:46]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-01-27 04:37:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619423003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619423003/80001

[commit-bot: I haz the power, 2016-01-27 05:53:07]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-01-27 05:54:25]

Description was changed from

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail when a library has no source files
in them.

BUG=361137
==========

to

==========
Create //ui/base/ime:text_input_base target.

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail when a library has no source files
in them.

BUG=361137

Committed: https://crrev.com/8dd34a13c2228f86066da8ba3a22d02321ab6caa
Cr-Commit-Position: refs/heads/master@{#371744}
==========

[commit-bot: I haz the power, 2016-01-27 05:54:26]

Patchset 3 (id:??) landed as
https://crrev.com/8dd34a13c2228f86066da8ba3a22d02321ab6caa
Cr-Commit-Position: refs/heads/master@{#371744}