Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: ui/base/ime/BUILD.gn

Issue 1619423003: Create //ui/base/ime:text_input_base target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change GYP target type to none. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/ime/ui_base_ime.gyp » ('j') | ui/ozone/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/BUILD.gn
diff --git a/ui/base/ime/BUILD.gn b/ui/base/ime/BUILD.gn
index 9cf4606bed3f692b7a65af969c338fe83311851c..b54f15c55f518cd7ca020870ddf97a25156dddf6 100644
--- a/ui/base/ime/BUILD.gn
+++ b/ui/base/ime/BUILD.gn
@@ -5,6 +5,14 @@
import("//build/config/ui.gni")
import("//testing/test.gni")
+source_set("text_input_types") {
sadrul 2016/01/26 17:50:38 I think you want group() here, instead of source_s
kylechar 2016/01/26 17:58:34 Discussed in person. Will leave it as source_set.
spang 2016/01/26 18:00:09 group() doesn't have have sources = [...] I think
+ sources = [
+ "text_input_flags.h",
+ "text_input_mode.h",
+ "text_input_type.h",
+ ]
+}
+
component("ime") {
output_name = "ui_base_ime"
sources = [
@@ -85,7 +93,6 @@ component("ime") {
"mock_input_method.h",
"text_input_client.cc",
"text_input_client.h",
- "text_input_type.h",
"ui_base_ime_export.h",
"win/imm32_manager.cc",
"win/imm32_manager.h",
@@ -111,6 +118,10 @@ component("ime") {
"//url",
]
+ public_deps = [
+ ":text_input_types",
+ ]
+
if (!use_aura || (!is_linux && !use_ozone)) {
sources -= [
"input_method_auralinux.cc",
« no previous file with comments | « no previous file | ui/base/ime/ui_base_ime.gyp » ('j') | ui/ozone/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698