Mouse press should focus on any types of form controls.

Source/core/rendering/RenderTheme.cpp

 /**
  * This file is part of the theme implementation for form controls in WebCore.
  *
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 674 matching lines @@
 void RenderTheme::adjustRepaintRect(const RenderObject* o, IntRect& r)
 {
 #if USE(NEW_THEME)
     m_theme->inflateControlPaintRect(o->style()->appearance(), controlStatesForRenderer(o), r, o->style()->effectiveZoom());
 #else
     UNUSED_PARAM(o);
     UNUSED_PARAM(r);
 #endif
 }
 
+bool RenderTheme::shouldDrawCommonFocusRing(RenderObject* renderer) const

[ojan, 2013/05/31 22:48:16]

I'm not really sure what "Common" means here.

[tkent, 2013/06/02 23:52:14]

We have three types of focus rings.
 - Dedicated to an appearance  (RenderTheme::supportsFocusRing==true)
 - outline:auto
 - non-auto outline (it might not be a focus ring)

I called the second "common."  I renamed it to "default" though I'm not sure
what's the best word.

+{
+    if (supportsFocusRing(renderer->style()))
+        return false;
+    if (!renderer->style()->hasAppearance())
+        return true;
+    Node* node = renderer->node();
+    if (!node)
+        return true;
+    // We can't use RenderTheme::isFocused because outline:auto might be
+    // specified to non-:focus rulesets.
+    if (node->focused() && !node->shouldHaveFocusAppearance())
+        return false;
+    return true;
+}
+
 bool RenderTheme::supportsFocusRing(const RenderStyle* style) const
 {
     return (style->hasAppearance() && style->appearance() != TextFieldPart && style->appearance() != TextAreaPart && style->appearance() != MenulistButtonPart && style->appearance() != ListboxPart);
 }
 
 bool RenderTheme::stateChanged(RenderObject* o, ControlState state) const
 {
     // Default implementation assumes the controls don't respond to changes in :hover state
     if (state == HoverState && !supportsHover(o->style()))
         return false;
@@ skipping 86 matching lines @@
 
 bool RenderTheme::isFocused(const RenderObject* o) const
 {
     Node* node = o->node();
     if (!node)
         return false;
 
     node = node->focusDelegate();
     Document* document = node->document();
     Frame* frame = document->frame();
-    return node == document->focusedNode() && frame && frame->selection()->isFocusedAndActive();
+    return node == document->focusedNode() && node->shouldHaveFocusAppearance() && frame && frame->selection()->isFocusedAndActive();
 }
 
 bool RenderTheme::isPressed(const RenderObject* o) const
 {
     if (!o->node())
         return false;
     return o->node()->active();
 }
 
 bool RenderTheme::isSpinUpButtonPartPressed(const RenderObject* o) const
@@ skipping 568 matching lines @@
 
     // padding - not honored by WinIE, needs to be removed.
     style->resetPadding();
 
     // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
     // for now, we will not honor it.
     style->resetBorder();
 }
 
 } // namespace WebCore