Mouse press should focus on any types of form controls.

Source/core/html/HTMLFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 37 matching lines @@
     , m_disabled(false)
     , m_isReadOnly(false)
     , m_isRequired(false)
     , m_valueMatchesRenderer(false)
     , m_ancestorDisabledState(AncestorDisabledStateUnknown)
     , m_dataListAncestorState(Unknown)
     , m_willValidateInitialized(false)
     , m_willValidate(true)
     , m_isValid(true)
     , m_wasChangedSinceLastFormControlChangeEvent(false)
+    , m_wasFocusedByMouse(false)
     , m_hasAutofocused(false)
 {
     setForm(form ? form : findFormAncestor());
     setHasCustomStyleCallbacks();
 }
 
 HTMLFormControlElement::~HTMLFormControlElement()
 {
 }
 
@@ skipping 246 matching lines @@
     // HTMLElement::isFocusable handles visibility and calls suportsFocus which
     // will cover the disabled case.
     return HTMLElement::isFocusable();
 }
 
 bool HTMLFormControlElement::isKeyboardFocusable(KeyboardEvent*) const
 {
     return isFocusable() && document()->frame();
 }
 
-bool HTMLFormControlElement::isMouseFocusable() const
+bool HTMLFormControlElement::shouldShowFocusRingOnMouseFocus() const
 {
     return false;
 }
 
+void HTMLFormControlElement::dispatchFocusEvent(PassRefPtr<Node> oldFocusedNode, FocusDirection direction)
+{
+    m_wasFocusedByMouse = direction == FocusDirectionMouse;
+    HTMLElement::dispatchFocusEvent(oldFocusedNode, direction);
+}
+
+bool HTMLFormControlElement::shouldHaveFocusAppearance() const
+{
+    return shouldShowFocusRingOnMouseFocus() || !m_wasFocusedByMouse;
+}
+
+void HTMLFormControlElement::willHandleKeyDownEvent()

[ojan, 2013/05/31 22:48:16]

Could this instead be HTMLFormControlElement::defaultEventHandler? Then you
wouldn't need to sprinkle willHandleKeyDownEvent calls in all the other classes.

[tkent, 2013/06/02 23:52:14]

It's hard because there are many "if (event->defaultHandled()) return" in
sub-classes. We need to fix every such instances.  I understand calling
willHandleKeyDownEvent manually is not good. New patch introduces
Node::willCallDefaultEventHandler.

+{
+    if (!m_wasFocusedByMouse)
+        return;
+    m_wasFocusedByMouse = false;

[ojan, 2013/05/31 22:48:16]

Do you also need to handle blur and clear this bool?

[tkent, 2013/06/02 23:52:14]

It's unnecessary. The flag should be referred only if focused().  I added some
ASSERTs in the new patch.

+    if (renderer())
+        renderer()->repaint();
+}
+
+
 short HTMLFormControlElement::tabIndex() const
 {
     // Skip the supportsFocus check in HTMLElement.
     return Element::tabIndex();
 }
 
 bool HTMLFormControlElement::recalcWillValidate() const
 {
     if (m_dataListAncestorState == Unknown) {
         for (ContainerNode* ancestor = parentNode(); ancestor; ancestor = ancestor->parentNode()) {
@@ skipping 134 matching lines @@
 }
 
 void HTMLFormControlElement::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
 {
     MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);
     LabelableElement::reportMemoryUsage(memoryObjectInfo);
     info.addMember(m_validationMessage, "validationMessage");
 }
 
 } // namespace Webcore