Source/core/html/BaseDateAndTimeInputType.cpp - Issue 16194013: Mouse press should focus on any types of form controls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/BaseDateAndTimeInputType.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/html/BaseDateAndTimeInputType.h ('k') | Source/core/html/BaseMultipleFieldsDateAndTimeInputType.h » ('j') | Source/core/html/HTMLFormControlElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 157 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
168 bool BaseDateAndTimeInputType::shouldRespectListAttribute()	168 bool BaseDateAndTimeInputType::shouldRespectListAttribute()

169 {	169 {

170 return InputType::themeSupportsDataListUI(this);	170 return InputType::themeSupportsDataListUI(this);

171 }	171 }

172	172

173 bool BaseDateAndTimeInputType::valueMissing(const String& value) const	173 bool BaseDateAndTimeInputType::valueMissing(const String& value) const

174 {	174 {

175 return element()->isRequired() && value.isEmpty();	175 return element()->isRequired() && value.isEmpty();

176 }	176 }

177	177

	178 bool BaseDateAndTimeInputType::shouldShowFocusRingOnMouseFocus() const

	179 {

	180 return true;

	181 }

	182

178 } // namespace WebCore	183 } // namespace WebCore

OLD	NEW