content/public/renderer/render_frame_observer.h - Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more per Dmitry Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/renderer/render_frame_observer.h

diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h

index 43182a691f8ec1218e182a39d0520070b715917b..ea2ba2b7035df6252c77e9ba80eb75620c01f59b 100644

--- a/content/public/renderer/render_frame_observer.h

+++ b/content/public/renderer/render_frame_observer.h

@@ -96,7 +96,7 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,

virtual void DetailedConsoleMessageAdded(const base::string16& message,

const base::string16& source,

const base::string16& stack_trace,

- int32_t line_number,

+ uint32_t line_number,

int32_t severity_level) {}

// Called when an interesting (from document lifecycle perspective),

« base/pickle.cc ('K') | « content/public/common/gpu_memory_stats.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »