Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: content/public/renderer/render_frame_observer.h

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more per Dmitry Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
6 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_ 6 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 89
90 // Called when we receive a console message from Blink for which we requested 90 // Called when we receive a console message from Blink for which we requested
91 // extra details (like the stack trace). |message| is the error message, 91 // extra details (like the stack trace). |message| is the error message,
92 // |source| is the Blink-reported source of the error (either external or 92 // |source| is the Blink-reported source of the error (either external or
93 // internal), and |stack_trace| is the stack trace of the error in a 93 // internal), and |stack_trace| is the stack trace of the error in a
94 // human-readable format (each frame is formatted as 94 // human-readable format (each frame is formatted as
95 // "\n at function_name (source:line_number:column_number)"). 95 // "\n at function_name (source:line_number:column_number)").
96 virtual void DetailedConsoleMessageAdded(const base::string16& message, 96 virtual void DetailedConsoleMessageAdded(const base::string16& message,
97 const base::string16& source, 97 const base::string16& source,
98 const base::string16& stack_trace, 98 const base::string16& stack_trace,
99 int32_t line_number, 99 uint32_t line_number,
100 int32_t severity_level) {} 100 int32_t severity_level) {}
101 101
102 // Called when an interesting (from document lifecycle perspective), 102 // Called when an interesting (from document lifecycle perspective),
103 // compositor-driven layout had happened. This is a reasonable hook to use 103 // compositor-driven layout had happened. This is a reasonable hook to use
104 // to inspect the document and layout information, since it is in a clean 104 // to inspect the document and layout information, since it is in a clean
105 // state and you won't accidentally force new layouts. 105 // state and you won't accidentally force new layouts.
106 // The interestingness of layouts is explained in WebMeaningfulLayout.h. 106 // The interestingness of layouts is explained in WebMeaningfulLayout.h.
107 virtual void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) {} 107 virtual void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) {}
108 108
109 // Called when a compositor frame has committed. 109 // Called when a compositor frame has committed.
(...skipping 28 matching lines...) Expand all
138 RenderFrame* render_frame_; 138 RenderFrame* render_frame_;
139 // The routing ID of the associated RenderFrame. 139 // The routing ID of the associated RenderFrame.
140 int routing_id_; 140 int routing_id_;
141 141
142 DISALLOW_COPY_AND_ASSIGN(RenderFrameObserver); 142 DISALLOW_COPY_AND_ASSIGN(RenderFrameObserver);
143 }; 143 };
144 144
145 } // namespace content 145 } // namespace content
146 146
147 #endif // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_ 147 #endif // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698