components/autofill/core/common/form_field_data_unittest.cc - Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/form_field_data_unittest.cc

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more per Dmitry Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/common/form_field_data_unittest.cc

diff --git a/components/autofill/core/common/form_field_data_unittest.cc b/components/autofill/core/common/form_field_data_unittest.cc

index dc17277e341a82d55d8394281a22bf22832dbf08..3297f738ca09fda5862871c7c21045ce34756191 100644

--- a/components/autofill/core/common/form_field_data_unittest.cc

+++ b/components/autofill/core/common/form_field_data_unittest.cc

@@ -38,7 +38,7 @@ void WriteCommonSection1(const FormFieldData& data, base::Pickle* pickle) {

pickle->WriteString16(data.value);

pickle->WriteString(data.form_control_type);

pickle->WriteString(data.autocomplete_attribute);

- pickle->WriteSizeT(data.max_length);

+ pickle->WriteUInt32(data.max_length);

pickle->WriteBool(data.is_autofilled);

pickle->WriteBool(data.is_checked);

pickle->WriteBool(data.is_checkable);

« base/pickle.cc ('K') | « components/autofill/core/common/form_field_data.cc ('k') | components/web_cache/browser/web_cache_manager.cc » ('j') | no next file with comments »