Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: components/autofill/core/common/form_field_data.cc

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more per Dmitry Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/form_field_data.cc
diff --git a/components/autofill/core/common/form_field_data.cc b/components/autofill/core/common/form_field_data.cc
index 7b8d10530d424d6b6ed074839da294398c59ea50..f3cebf2460d4ccf5e3b6f71c17cbf1e48714fced 100644
--- a/components/autofill/core/common/form_field_data.cc
+++ b/components/autofill/core/common/form_field_data.cc
@@ -57,7 +57,7 @@ bool DeserializeCommonSection1(base::PickleIterator* iter,
iter->ReadString16(&field_data->value) &&
iter->ReadString(&field_data->form_control_type) &&
iter->ReadString(&field_data->autocomplete_attribute) &&
- iter->ReadSizeT(&field_data->max_length) &&
+ iter->ReadUInt32(&field_data->max_length) &&
iter->ReadBool(&field_data->is_autofilled) &&
iter->ReadBool(&field_data->is_checked) &&
iter->ReadBool(&field_data->is_checkable) &&
@@ -155,7 +155,7 @@ void SerializeFormFieldData(const FormFieldData& field_data,
pickle->WriteString16(field_data.value);
pickle->WriteString(field_data.form_control_type);
pickle->WriteString(field_data.autocomplete_attribute);
- pickle->WriteSizeT(field_data.max_length);
+ pickle->WriteUInt32(field_data.max_length);
pickle->WriteBool(field_data.is_autofilled);
pickle->WriteBool(field_data.is_checked);
pickle->WriteBool(field_data.is_checkable);

Powered by Google App Engine
This is Rietveld 408576698