Factor out xcode c/cpp settings into variables to apply to cmake builds

Factor out xcode c/cpp settings into variables to apply to cmake builds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619243003

Committed: https://skia.googlesource.com/skia/+/32235eac4b5c625e639757b8247f6e64ce4dc4c8

[bsalomon, 2016-01-22 18:23:04]

Description was changed from

==========
update

BUG=skia:
==========

to

==========
update

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-22 18:24:43]

Description was changed from

==========
update

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Factor out xcode c/cpp settings into variables to apply to cmake builds.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-22 18:24:43]

bsalomon@google.com changed reviewers:
+ mtklein@google.com

[bsalomon, 2016-01-22 18:25:32]

I locally checked that the flags appear on the command line in builds with
ninja, xcode, and cmake

[bsalomon, 2016-01-22 18:26:24]

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:487: '-fno-threadsafe-statics',
wasn't totally sure which list this belonged in

[mtklein, 2016-01-22 18:45:21]

lgtm

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:487: '-fno-threadsafe-statics',
On 2016/01/22 18:26:24, bsalomon wrote:
> wasn't totally sure which list this belonged in

Either place seems fine to me if it works, but I think this is technically the
correct place to put it.  Threadsafe statics are a C++11 feature we're
explicitly disabling.  Before we set -std=c++11, they were a non-standard
GCC+Clang feature.  I think GCC and Clang also make static threadsafe for C, but
I really don't care too much about how C code (third_party) behaves as along as
our C++ statics are not thread safe.  That's Chrome's least-common-denominator,
where they're not threadsafe with MSVC until MSVC 2015.

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:544: 'OTHER_CPLUSPLUSFLAGS': [
# Used by Ninja and XCode.

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:552: 'cflags': [
# Used by CMake.

[bsalomon, 2016-01-22 20:03:05]

Please take another look. I had to change the way we re-enable RTTI for icuuc
and when skia_sanitzer is used. Also, I had to put back:

'CLANG_CXX_LIBRARY':                         'libc++',

for the ninja build to link correctly.

Checked that dm and nanobench compile when skia_sanitizer=address.

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:544: 'OTHER_CPLUSPLUSFLAGS': [
On 2016/01/22 18:45:21, mtklein wrote:
> # Used by Ninja and XCode.

Done.

https://codereview.chromium.org/1619243003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:552: 'cflags': [
On 2016/01/22 18:45:21, mtklein wrote:
> # Used by CMake.

Done.

[mtklein, 2016-01-22 20:07:30]

still lgtm

As far as I'm concerned, if it doesn't break a bot, we can sort out any
ancillary stuff like asan-on-Mac as it comes up.

https://codereview.chromium.org/1619243003/diff/40001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1619243003/diff/40001/gyp/common_conditions.g...
gyp/common_conditions.gypi:552: '<@(common_c_and_cpp_flags)',
Oh wow, they're disjoint here but merged below... gotta love GYP.

[bsalomon, 2016-01-22 20:08:24]

https://codereview.chromium.org/1619243003/diff/40001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1619243003/diff/40001/gyp/common_conditions.g...
gyp/common_conditions.gypi:552: '<@(common_c_and_cpp_flags)',
On 2016/01/22 20:07:30, mtklein wrote:
> Oh wow, they're disjoint here but merged below... gotta love GYP.

Yeah... a surprise around every corner!

[bsalomon, 2016-01-22 20:38:54]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-22 20:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619243003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619243003/40001

[commit-bot: I haz the power, 2016-01-22 20:54:59]

Description was changed from

==========
Factor out xcode c/cpp settings into variables to apply to cmake builds.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Factor out xcode c/cpp settings into variables to apply to cmake builds.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32235eac4b5c625e639757b8247f6e64ce4dc4c8
==========

[commit-bot: I haz the power, 2016-01-22 20:55:00]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/32235eac4b5c625e639757b8247f6e64ce4dc4c8