Factor out xcode c/cpp settings into variables to apply to cmake builds

gyp/common_conditions.gypi

 # Copyright 2015 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # conditions used in both common.gypi and skia.gyp in chromium
 #
 {
   'defines': [
     'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
@@ skipping 453 matching lines @@
           }],
           [ 'skia_keep_frame_pointer', {
             'cflags': [ '-fno-omit-frame-pointer' ],
           }],
         ],
       },
     ],
 
     [ 'skia_os == "mac"',
       {
+        'variables': {
+            'common_c_and_cpp_flags': [
+              '-mssse3',
+              '-fvisibility=hidden',
+              '-fvisibility-inlines-hidden',
+              '-Wall',
+              '-Wextra',
+              '-Winit-self',
+              '-Wpointer-arith',
+              '-Wsign-compare',
+              '-Wno-unused-parameter',
+            ],
+            'common_cpp_flags': [
+              '-fno-threadsafe-statics',

[bsalomon, 2016/01/22 18:26:24]

wasn't totally sure which list this belonged in

[mtklein, 2016/01/22 18:45:21]

Either place seems fine to me if it works, but I think this is technically the
correct place to put it.  Threadsafe statics are a C++11 feature we're
explicitly disabling.  Before we set -std=c++11, they were a non-standard
GCC+Clang feature.  I think GCC and Clang also make static threadsafe for C, but
I really don't care too much about how C code (third_party) behaves as along as
our C++ statics are not thread safe.  That's Chrome's least-common-denominator,
where they're not threadsafe with MSVC until MSVC 2015.

+              '-fno-exceptions',
+              '-fno-rtti',
+              '-std=c++11',
+              '-stdlib=libc++'
+            ],
+        },
         'defines': [ 'SK_BUILD_FOR_MAC' ],
         'conditions': [
             # ANGLE for mac hits -Wunneeded-internal-declaration if this isn't set.
             [ 'skia_angle', { 'defines': [ 'YY_NO_INPUT' ], } ],
         ],
         'configurations': {
           'Coverage': {
             'xcode_settings': {
                'GCC_OPTIMIZATION_LEVEL': '0',
                'GCC_GENERATE_TEST_COVERAGE_FILES': 'YES',
@@ skipping 28 matching lines @@
                 '-include <(skia_sanitizer_blacklist)',             # Make every .cpp depend on it.
               ],
               # We want to pass -fsanitize=... to our final link call,
               # but not to libtool. OTHER_LDFLAGS is passed to both.
               # To trick GYP into doing what we want, we'll piggyback on
               # LIBRARY_SEARCH_PATHS, producing "-L/usr/lib -fsanitize=...".
               # The -L/usr/lib is redundant but innocuous: it's a default path.
               'LIBRARY_SEARCH_PATHS': [ '/usr/lib -fsanitize=<(skia_sanitizer)'],
             }],
           ],
-          'CLANG_CXX_LIBRARY':                         'libc++',
-          'CLANG_CXX_LANGUAGE_STANDARD':               'c++11',
-          'GCC_ENABLE_CPP_EXCEPTIONS':                 'NO',   # -fno-exceptions
-          'GCC_ENABLE_CPP_RTTI':                       'NO',   # -fno-rtti
-          'GCC_THREADSAFE_STATICS':                    'NO',   # -fno-threadsafe-statics
-          'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES',  # -mssse3
-          'GCC_SYMBOLS_PRIVATE_EXTERN':                'NO',   # -fvisibility=hidden
-          'GCC_INLINES_ARE_PRIVATE_EXTERN':            'NO',   # -fvisibility-inlines-hidden
           'GCC_CW_ASM_SYNTAX':                         'NO',   # remove -fasm-blocks
           'GCC_ENABLE_PASCAL_STRINGS':                 'NO',   # remove -mpascal-strings
-          'WARNING_CFLAGS': [
-            '-Wall',
-            '-Wextra',
-            '-Winit-self',
-            '-Wpointer-arith',
-            '-Wsign-compare',
-
-            '-Wno-unused-parameter',
+          'OTHER_CPLUSPLUSFLAGS': [

[mtklein, 2016/01/22 18:45:21]

# Used by Ninja and XCode.

[bsalomon, 2016/01/22 20:03:05]

Done.

+            '<@(common_cpp_flags)',
+            '<@(common_c_and_cpp_flags)',
+          ],
+          'OTHER_CFLAGS': [
+            '<@(common_c_and_cpp_flags)',
           ],
         },
+        'cflags': [

[mtklein, 2016/01/22 18:45:21]

# Used by CMake.

[bsalomon, 2016/01/22 20:03:05]

Done.

+          '<@(common_c_and_cpp_flags)',
+        ],
+        'cflags_cc': [
+          '<@(common_cpp_flags)',
+        ],
       },
     ],
 
     [ 'skia_os == "ios"',
       {
         'defines': [
           'SK_BUILD_FOR_IOS',
         ],
         'conditions' : [
           [ 'skia_warnings_as_errors', {
@@ skipping 108 matching lines @@
           'LD_RUNPATH_SEARCH_PATHS': ['@executable_path/.'],
       },
     }],
 
   ], # end 'conditions'
   # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details
   'xcode_settings': {
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }