Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1619013002: MD Downloads: vulcanize to pick up recent Polymer changes (Closed)

Created:
4 years, 11 months ago by Dan Beam
Modified:
4 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: vulcanize to pick up recent Polymer changes R=michaelpg@chromium.org BUG=none NOPRESUBMIT=true # for crisper.js Committed: https://crrev.com/1cbeb1c9e2f3ca9f274172ed5bfa18a8610b1855 Cr-Commit-Position: refs/heads/master@{#370853}

Patch Set 1 #

Total comments: 1

Patch Set 2 : --script-in-head=false #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -328 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 26 chunks +110 lines, -48 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanize.py View 1 1 chunk +4 lines, -2 lines 1 comment Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 56 chunks +320 lines, -278 lines 0 comments Download

Dependent Patchsets:

Issue 1613233003 Patch 20001

Messages

Total messages: 15 (6 generated)
Dan Beam
4 years, 11 months ago (2016-01-21 21:11:59 UTC) #1
michaelpg
https://codereview.chromium.org/1619013002/diff/1/chrome/browser/resources/md_downloads/vulcanized.html File chrome/browser/resources/md_downloads/vulcanized.html (right): https://codereview.chromium.org/1619013002/diff/1/chrome/browser/resources/md_downloads/vulcanized.html#newcode1 chrome/browser/resources/md_downloads/vulcanized.html:1: <!DOCTYPE html><html i18n-values="dir:textdirection;lang:language"><head><script src="crisper.js" defer=""></script><!-- just checking: since this ...
4 years, 11 months ago (2016-01-21 21:22:31 UTC) #2
Dan Beam
https://codereview.chromium.org/1619013002/diff/20001/chrome/browser/resources/md_downloads/vulcanize.py File chrome/browser/resources/md_downloads/vulcanize.py (right): https://codereview.chromium.org/1619013002/diff/20001/chrome/browser/resources/md_downloads/vulcanize.py#newcode70 chrome/browser/resources/md_downloads/vulcanize.py:70: '--script-in-head', 'false', ^ needed this
4 years, 11 months ago (2016-01-21 23:35:12 UTC) #3
michaelpg
lgtm
4 years, 11 months ago (2016-01-21 23:44:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619013002/20001
4 years, 11 months ago (2016-01-21 23:57:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/137904)
4 years, 11 months ago (2016-01-22 00:08:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619013002/20001
4 years, 11 months ago (2016-01-22 00:10:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 00:46:38 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 00:48:14 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1cbeb1c9e2f3ca9f274172ed5bfa18a8610b1855
Cr-Commit-Position: refs/heads/master@{#370853}

Powered by Google App Engine
This is Rietveld 408576698