Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1613233003: MD Downloads: make Ctrl+f invoke in-page search (Closed)

Created:
4 years, 11 months ago by Dan Beam
Modified:
4 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-vulcanize
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: make Ctrl+f invoke in-page search R=michaelpg@chromium.org BUG=578323 Committed: https://crrev.com/60ebcccd01f6faaa0c85fe583bb73d2032e4f450 Cr-Commit-Position: refs/heads/master@{#370881}

Patch Set 1 #

Total comments: 9

Patch Set 2 : rework, revulc #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -36 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 7 chunks +58 lines, -18 lines 0 comments Download
M chrome/browser/resources/md_downloads/downloads.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.js View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js View 1 2 chunks +47 lines, -16 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (6 generated)
Dan Beam
4 years, 11 months ago (2016-01-21 21:15:14 UTC) #1
michaelpg
https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode43 chrome/browser/resources/md_downloads/toolbar.js:43: var searchInput = this.$ && this.$['search-input']; this should already ...
4 years, 11 months ago (2016-01-21 22:04:14 UTC) #2
Dan Beam
https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode48 chrome/browser/resources/md_downloads/toolbar.js:48: searchInput.focus(); On 2016/01/21 22:04:14, michaelpg wrote: > doesn't this ...
4 years, 11 months ago (2016-01-21 22:14:47 UTC) #3
michaelpg
https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode48 chrome/browser/resources/md_downloads/toolbar.js:48: searchInput.focus(); On 2016/01/21 22:14:46, Dan Beam wrote: > On ...
4 years, 11 months ago (2016-01-21 22:19:01 UTC) #4
Dan Beam
https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode43 chrome/browser/resources/md_downloads/toolbar.js:43: var searchInput = this.$ && this.$['search-input']; On 2016/01/21 22:04:14, ...
4 years, 11 months ago (2016-01-21 23:39:27 UTC) #5
michaelpg
https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/1613233003/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode48 chrome/browser/resources/md_downloads/toolbar.js:48: searchInput.focus(); On 2016/01/21 23:39:27, Dan Beam wrote: > On ...
4 years, 11 months ago (2016-01-21 23:43:35 UTC) #6
Dan Beam
https://codereview.chromium.org/1613233003/diff/20001/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right): https://codereview.chromium.org/1613233003/diff/20001/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js#newcode103 ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:103: toggleShowingSearch_: function() { On 2016/01/21 23:43:35, michaelpg wrote: > ...
4 years, 11 months ago (2016-01-21 23:54:24 UTC) #7
michaelpg
lgtm
4 years, 11 months ago (2016-01-21 23:56:57 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 1619013002 Patch 20001). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-21 23:59:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613233003/20001
4 years, 11 months ago (2016-01-22 00:54:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 02:26:53 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 02:28:52 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60ebcccd01f6faaa0c85fe583bb73d2032e4f450
Cr-Commit-Position: refs/heads/master@{#370881}

Powered by Google App Engine
This is Rietveld 408576698