|
Revert of Start of display management for mus (patchset #5 id:80001 of https://codereview.chromium.org/1615023004/ )
Reason for revert:
Consistently causing crashes on mash startup:
[0122/110054:FATAL:default_logger_impl.cc(51)] Check failed: ptr_.
#0 0x7fc46007507e base::debug::StackTrace::StackTrace()
#1 0x7fc4600c0bcf logging::LogMessage::~LogMessage()
#2 0x7fc45fe9ac30 mojo::internal::(anonymous namespace)::LogMessage()
#3 0x7fc45fe9a2e5 mojo::internal::LogMessage::~LogMessage()
#4 0x7fc45de1a33c mojo::StructPtr<>::operator->()
#5 0x7fc45fff3fc7 mus::ws::ConnectionManager::AddObserver()
#6 0x7fc45fe327f3 mus::mojom::DisplayManagerStub::Accept()
#7 0x7fc45fe07f64 mojo::internal::Router::HandleIncomingMessage()
#8 0x7fc45fe07b41 mojo::internal::Router::HandleIncomingMessageThunk::Accept()
#9 0x7fc45fe32a9e mus::mojom::DisplayManagerRequestValidator::Accept()
Original issue's description:
> Start of display management for mus
>
> This adds a DisplayManager interface that you get from mus. You can
> then attach an observer to observe display related changes.
>
> BUG= 548429
> TEST=none
> R=ben@chromium.org
>
> Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
> Cr-Commit-Position: refs/heads/master@{#370880}
TBR=ben@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 548429
Committed: https://crrev.com/3537f56b3e87d722b1e7caa3d996874f3199f750
Cr-Commit-Position: refs/heads/master@{#371005}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+127 lines, -533 lines) |
Patch |
 |
M |
ash/display/screen_ash.cc
|
View
|
|
4 chunks |
+41 lines, -6 lines |
0 comments
|
Download
|
 |
M |
base/threading/thread_restrictions.h
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/mus/mus_app.h
|
View
|
|
5 chunks |
+3 lines, -12 lines |
0 comments
|
Download
|
 |
M |
components/mus/mus_app.cc
|
View
|
|
3 chunks |
+6 lines, -31 lines |
0 comments
|
Download
|
 |
M |
components/mus/public/interfaces/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
D |
components/mus/public/interfaces/display.mojom
|
View
|
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
M |
components/mus/public/interfaces/window_manager_constants.mojom
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
components/mus/ws/connection_manager.h
|
View
|
|
6 chunks |
+1 line, -18 lines |
0 comments
|
Download
|
 |
M |
components/mus/ws/connection_manager.cc
|
View
|
|
3 chunks |
+2 lines, -36 lines |
0 comments
|
Download
|
 |
M |
components/mus/ws/display_manager.h
|
View
|
|
4 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/mus/ws/display_manager.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/mus/ws/window_tree_host_impl.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/mus/ws/window_tree_host_impl.cc
|
View
|
|
3 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
 |
M |
components/mus/ws/window_tree_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/web_view/frame_connection.cc
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/gfx/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
ui/gfx/display_finder.h
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
D |
ui/gfx/display_finder.cc
|
View
|
|
1 chunk |
+0 lines, -50 lines |
0 comments
|
Download
|
 |
M |
ui/gfx/gfx.gyp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/views/mus/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
ui/views/mus/screen_mus.h
|
View
|
|
1 chunk |
+0 lines, -71 lines |
0 comments
|
Download
|
 |
D |
ui/views/mus/screen_mus.cc
|
View
|
|
1 chunk |
+0 lines, -203 lines |
0 comments
|
Download
|
 |
M |
ui/views/mus/window_manager_connection.h
|
View
|
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/views/mus/window_manager_connection.cc
|
View
|
|
3 chunks |
+66 lines, -3 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|