Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1618773002: Do not try to get fragment input locations with CHROMIUM_path_rendering (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
CC:
reviews_skia.org, Sami Väisänen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do not try to get fragment input locations with CHROMIUM_path_rendering Do not try to get fragment input locations with CHROMIUM_path_rendering, it uses the binding mechanism in CHROMIUM_path_rendering BUG=skia:2992 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618773002 Committed: https://skia.googlesource.com/skia/+/7bdb05d5c294eb332a18d09b81a99ed1125c9525

Patch Set 1 #

Patch Set 2 : win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Kimmo Kinnunen
Fixing an unfortunate typo..
4 years, 11 months ago (2016-01-21 13:07:06 UTC) #3
Kimmo Kinnunen
4 years, 11 months ago (2016-01-21 13:19:30 UTC) #5
joshualitt
On 2016/01/21 13:19:30, Kimmo Kinnunen wrote: lgtm
4 years, 11 months ago (2016-01-21 14:06:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618773002/1
4 years, 11 months ago (2016-01-22 06:41:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-22 08:42:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618773002/20001
4 years, 11 months ago (2016-01-25 08:33:56 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 08:47:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7bdb05d5c294eb332a18d09b81a99ed1125c9525

Powered by Google App Engine
This is Rietveld 408576698