chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java - Issue 1618413002: Change the CBD dialog on Android to a PreferenceFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

Issue 1618413002: Change the CBD dialog on Android to a PreferenceFragment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unused variable. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/xml/clear_browsing_data_dialog.xml ('K') | « chrome/android/java/res/xml/privacy_preferences.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataDialogFragment.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataDialogFragment.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

index 09e2bd4e2a9f3f36283e8a33724893908b0285e8..60cad358a9943fef306c000f0f92ff1d2c5d022b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

@@ -71,7 +71,7 @@ import org.chromium.chrome.browser.preferences.Preferences;

import org.chromium.chrome.browser.preferences.PreferencesLauncher;

import org.chromium.chrome.browser.preferences.autofill.AutofillPreferences;

import org.chromium.chrome.browser.preferences.password.SavePasswordsPreferences;

-import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferences;

+import org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataDialogFragment;

import org.chromium.chrome.browser.preferences.website.SingleWebsitePreferences;

import org.chromium.chrome.browser.printing.PrintingControllerFactory;

import org.chromium.chrome.browser.rlz.RevenueStats;

@@ -524,10 +524,7 @@ public class ChromeApplication extends ContentApplication {

return;

}

Intent intent = PreferencesLauncher.createIntentForSettingsPage(activity,

- PrivacyPreferences.class.getName());

- Bundle arguments = new Bundle();

- arguments.putBoolean(PrivacyPreferences.SHOW_CLEAR_BROWSING_DATA_EXTRA, true);

- intent.putExtra(Preferences.EXTRA_SHOW_FRAGMENT_ARGUMENTS, arguments);

+ ClearBrowsingDataDialogFragment.class.getName());

activity.startActivity(intent);

}