Change the CBD dialog on Android to a PreferenceFragment

chrome/android/java/res/xml/clear_browsing_data_dialog.xml

Index: chrome/android/java/res/xml/clear_browsing_data_dialog.xml
diff --git a/chrome/android/java/res/xml/clear_browsing_data_dialog.xml b/chrome/android/java/res/xml/clear_browsing_data_dialog.xml
new file mode 100644
index 0000000000000000000000000000000000000000..ae26d457361a27788ce5f9e0c55990cd914fa491
--- /dev/null
+++ b/chrome/android/java/res/xml/clear_browsing_data_dialog.xml
@@ -0,0 +1,51 @@
+<?xml version="1.0" encoding="utf-8"?>

[newt (away), 2016/01/29 20:16:02]

This should be called clear_browsing_data_preferences.xml to follow the existing
file naming pattern

[msramek, 2016/02/02 12:19:51]

Done.

+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<PreferenceScreen
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:chrome="http://schemas.android.com/apk/res-auto">
+
+    <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference
+        android:key="clear_browsing_data_history_checkbox"

[newt (away), 2016/01/29 20:16:02]

These keys don't need to be globally unique. They could probably be terser, say,
"clear_history_checkbox" or even "clear_history".

I'd also add android:persistent="false" to each of these. That'll ensure that
Android doesn't read and store the values of these checkboxes in shared prefs,
which is unnecessary, duplicates knowledge, and -- the best part -- will cause
ClassCastExceptions if the type of these preferences ever changes (e.g. from a
checkbox to a multiple-choice pref).

[msramek, 2016/02/02 12:19:51]

Done. I'll keep the "checkbox" part, so that it doesn't sound like
"clear_history" and "clear_button" are the same category.

+        android:title="@string/clear_history_title" />
+
+    <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference
+        android:key="clear_browsing_data_cache_checkbox"
+        android:title="@string/clear_cache_title" />
+
+    <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference
+        android:key="clear_browsing_data_cookies_checkbox"
+        android:title="@string/clear_cookies_and_site_data_title" />
+
+    <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference
+        android:key="clear_browsing_data_passwords_checkbox"
+        android:title="@string/clear_passwords_title" />
+
+    <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference
+        android:key="clear_browsing_data_form_data_checkbox"
+        android:title="@string/clear_formdata_title" />

[newt (away), 2016/01/29 20:16:02]

might as well spell this "form_data" instead of "formdata" for consistency

[msramek, 2016/02/02 12:19:51]

Agreed, changed it. It was this way in android_chrome_strings.grd.

+
+    <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference
+        android:key="clear_browsing_data_bookmarks_checkbox"
+        android:title="@string/clear_bookmarks_title" />
+
+    <org.chromium.chrome.browser.preferences.ButtonPreference
+        android:key="clear_browsing_data_clear_button"
+        android:title="@string/clear_data_delete" />
+
+    <org.chromium.chrome.browser.preferences.TextMessagePreference
+        android:key="clear_browsing_data_footnote"
+        android:title="@string/clear_browsing_data_footnote" />
+
+    <org.chromium.chrome.browser.preferences.TextMessagePreference
+        android:key="clear_browsing_data_footnote_synced"
+        android:title="@string/clear_browsing_data_footnote_synced" />
+
+    <org.chromium.chrome.browser.preferences.LearnMorePreference
+        android:key="clear_browsing_data_learn_more"

[newt (away), 2016/01/29 20:16:02]

No need to add keys for Preferences that aren't referenced from code. The
absence of "key" indicates at a glance that this preference isn't modified
dynamically, which makes understanding this file a bit easier.

[msramek, 2016/02/02 12:19:51]

Done. Makes sense. I thought it was a good practice to name everything :)

+        android:title="@string/learn_more"
+        chrome:helpContext="@string/help_context_clear_browsing_data" />
+
+</PreferenceScreen>