chrome/android/java/res/xml/clear_browsing_data_dialog.xml - Issue 1618413002: Change the CBD dialog on Android to a PreferenceFragment

Side by Side Diff: chrome/android/java/res/xml/clear_browsing_data_dialog.xml

Issue 1618413002: Change the CBD dialog on Android to a PreferenceFragment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unused variable. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/values/values.xml ('K') | « chrome/android/java/res/values/values.xml ('k') | chrome/android/java/res/xml/privacy_preferences.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataDialogFragment.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2016/01/29 20:16:02 This should be called clear_browsing_data_preferen This should be called clear_browsing_data_preferences.xml to follow the existing file naming pattern msramek 2016/02/02 12:19:51 Done. Show quoted text On 2016/01/29 20:16:02, newt wrote: > This should be called clear_browsing_data_preferences.xml to follow the existing > file naming pattern Done.
	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <PreferenceScreen

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto">

	9

	10 <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference

	11 android:key="clear_browsing_data_history_checkbox"
	newt (away) 2016/01/29 20:16:02 These keys don't need to be globally unique. They These keys don't need to be globally unique. They could probably be terser, say, "clear_history_checkbox" or even "clear_history". I'd also add android:persistent="false" to each of these. That'll ensure that Android doesn't read and store the values of these checkboxes in shared prefs, which is unnecessary, duplicates knowledge, and -- the best part -- will cause ClassCastExceptions if the type of these preferences ever changes (e.g. from a checkbox to a multiple-choice pref). msramek 2016/02/02 12:19:51 Done. I'll keep the "checkbox" part, so that it do Show quoted text On 2016/01/29 20:16:02, newt wrote: > These keys don't need to be globally unique. They could probably be terser, say, > "clear_history_checkbox" or even "clear_history". > > I'd also add android:persistent="false" to each of these. That'll ensure that > Android doesn't read and store the values of these checkboxes in shared prefs, > which is unnecessary, duplicates knowledge, and -- the best part -- will cause > ClassCastExceptions if the type of these preferences ever changes (e.g. from a > checkbox to a multiple-choice pref). Done. I'll keep the "checkbox" part, so that it doesn't sound like "clear_history" and "clear_button" are the same category.
	12 android:title="@string/clear_history_title" />

	13

	14 <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference

	15 android:key="clear_browsing_data_cache_checkbox"

	16 android:title="@string/clear_cache_title" />

	17

	18 <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference

	19 android:key="clear_browsing_data_cookies_checkbox"

	20 android:title="@string/clear_cookies_and_site_data_title" />

	21

	22 <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference

	23 android:key="clear_browsing_data_passwords_checkbox"

	24 android:title="@string/clear_passwords_title" />

	25

	26 <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference

	27 android:key="clear_browsing_data_form_data_checkbox"

	28 android:title="@string/clear_formdata_title" />
	newt (away) 2016/01/29 20:16:02 might as well spell this "form_data" instead of "f might as well spell this "form_data" instead of "formdata" for consistency msramek 2016/02/02 12:19:51 Agreed, changed it. It was this way in android_chr Show quoted text On 2016/01/29 20:16:02, newt wrote: > might as well spell this "form_data" instead of "formdata" for consistency Agreed, changed it. It was this way in android_chrome_strings.grd.
	29

	30 <org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference

	31 android:key="clear_browsing_data_bookmarks_checkbox"

	32 android:title="@string/clear_bookmarks_title" />

	33

	34 <org.chromium.chrome.browser.preferences.ButtonPreference

	35 android:key="clear_browsing_data_clear_button"

	36 android:title="@string/clear_data_delete" />

	37

	38 <org.chromium.chrome.browser.preferences.TextMessagePreference

	39 android:key="clear_browsing_data_footnote"

	40 android:title="@string/clear_browsing_data_footnote" />

	41

	42 <org.chromium.chrome.browser.preferences.TextMessagePreference

	43 android:key="clear_browsing_data_footnote_synced"

	44 android:title="@string/clear_browsing_data_footnote_synced" />

	45

	46 <org.chromium.chrome.browser.preferences.LearnMorePreference

	47 android:key="clear_browsing_data_learn_more"
	newt (away) 2016/01/29 20:16:02 No need to add keys for Preferences that aren't re No need to add keys for Preferences that aren't referenced from code. The absence of "key" indicates at a glance that this preference isn't modified dynamically, which makes understanding this file a bit easier. msramek 2016/02/02 12:19:51 Done. Makes sense. I thought it was a good practic Show quoted text On 2016/01/29 20:16:02, newt wrote: > No need to add keys for Preferences that aren't referenced from code. The > absence of "key" indicates at a glance that this preference isn't modified > dynamically, which makes understanding this file a bit easier. Done. Makes sense. I thought it was a good practice to name everything :)
	48 android:title="@string/learn_more"

	49 chrome:helpContext="@string/help_context_clear_browsing_data" />

	50

	51 </PreferenceScreen>

OLD	NEW