[interpreter, debugger] abstraction for source position calculation.

[interpreter, debugger] abstraction for source position calculation.

This change adds AbstractCode, which can be either Code or
BytecodeArray, and adds methods to calculate source position based
on that. Also cleans up to use code offsets instead of raw PC
where possible, and consistently uses the offset from instruction
start (as opposed to code object start).

R=rmcilroy@chromium.org, vogelheim@chromium.org
BUG=v8:4690
LOG=N

Committed: https://crrev.com/55438d60847c4df4579539ec48c60ec11cd522c4
Cr-Commit-Position: refs/heads/master@{#33579}

[rmcilroy, 2016-01-22 19:16:34]

Lgtm with a couple of nits.

https://codereview.chromium.org/1618343002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/1618343002/diff/1/src/debug/debug.cc#newcode1502
src/debug/debug.cc:1502: // has stopped.
Nit - could you add a comment on the -1 here too.

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc#newcode901
src/frames.cc:901: HeapObject* abstract_code, int code_offset,
Is there a reason this can't be AbstractCode type.

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc#newcode1005
src/frames.cc:1005: int code_offset;
Could this still be unsigned? It should never be negative right?

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc#newcode1018
src/frames.cc:1018: code_offset = 0;
Could this use GetBytecodeOffset now?

https://codereview.chromium.org/1618343002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1618343002/diff/1/src/objects.cc#newcode14290
src/objects.cc:14290: return code->SourcePosition(pc);
Nit, could you make SourcePosition take the offset here to behave like
BytevodeArray (a TODO for a later CL is fine if it's invasive).

[vogelheim, 2016-01-25 17:29:03]

lgtm

[still learning; so I actually don't have much to add here.]

[Yang, 2016-01-28 09:09:53]

https://codereview.chromium.org/1618343002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/1618343002/diff/1/src/debug/debug.cc#newcode1502
src/debug/debug.cc:1502: // has stopped.
On 2016/01/22 19:16:34, rmcilroy wrote:
> Nit - could you add a comment on the -1 here too.

Done.

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc#newcode901
src/frames.cc:901: HeapObject* abstract_code, int code_offset,
On 2016/01/22 19:16:34, rmcilroy wrote:
> Is there a reason this can't be AbstractCode type.

It can be. But then the caller would have to do the casting. Done.

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc#newcode1005
src/frames.cc:1005: int code_offset;
On 2016/01/22 19:16:34, rmcilroy wrote:
> Could this still be unsigned? It should never be negative right?

Done.

https://codereview.chromium.org/1618343002/diff/1/src/frames.cc#newcode1018
src/frames.cc:1018: code_offset = 0;
On 2016/01/22 19:16:34, rmcilroy wrote:
> Could this use GetBytecodeOffset now?

No. The frame object is still an OptimizedFrame. The translation does not offer
a bytecode offset from what I can see.

https://codereview.chromium.org/1618343002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1618343002/diff/1/src/objects.cc#newcode14290
src/objects.cc:14290: return code->SourcePosition(pc);
On 2016/01/22 19:16:34, rmcilroy wrote:
> Nit, could you make SourcePosition take the offset here to behave like
> BytevodeArray (a TODO for a later CL is fine if it's invasive).

Done.

[Yang, 2016-01-28 09:11:17]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 09:11:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618343002/20001

[ulan, 2016-01-28 09:11:36]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-01-28 09:11:37]

lgtm

[commit-bot: I haz the power, 2016-01-28 09:16:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 09:16:02]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Yang, 2016-01-28 09:17:50]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-01-28 09:17:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, vogelheim@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1618343002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-01-28 09:17:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618343002/40001

[commit-bot: I haz the power, 2016-01-28 09:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 09:24:09]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Yang, 2016-01-28 10:42:04]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-01-28 10:42:04]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
rmcilroy@chromium.org, vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1618343002/#ps60001
(title: "casts")

[commit-bot: I haz the power, 2016-01-28 10:42:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618343002/60001

[commit-bot: I haz the power, 2016-01-28 11:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 11:03:58]

Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/631)
  v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Yang, 2016-01-28 11:48:28]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-01-28 11:48:29]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
rmcilroy@chromium.org, vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1618343002/#ps80001
(title: "remove bogus assertion")

[commit-bot: I haz the power, 2016-01-28 11:48:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618343002/80001

[commit-bot: I haz the power, 2016-01-28 12:12:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-28 12:12:34]

Description was changed from

==========
[interpreter, debugger] abstraction for source position calculation.

This change adds AbstractCode, which can be either Code or
BytecodeArray, and adds methods to calculate source position based
on that. Also cleans up to use code offsets instead of raw PC
where possible, and consistently uses the offset from instruction
start (as opposed to code object start).

R=rmcilroy@chromium.org, vogelheim@chromium.org
BUG=v8:4690
LOG=N
==========

to

==========
[interpreter, debugger] abstraction for source position calculation.

This change adds AbstractCode, which can be either Code or
BytecodeArray, and adds methods to calculate source position based
on that. Also cleans up to use code offsets instead of raw PC
where possible, and consistently uses the offset from instruction
start (as opposed to code object start).

R=rmcilroy@chromium.org, vogelheim@chromium.org
BUG=v8:4690
LOG=N

Committed: https://crrev.com/55438d60847c4df4579539ec48c60ec11cd522c4
Cr-Commit-Position: refs/heads/master@{#33579}
==========

[commit-bot: I haz the power, 2016-01-28 12:12:35]

Patchset 5 (id:??) landed as
https://crrev.com/55438d60847c4df4579539ec48c60ec11cd522c4
Cr-Commit-Position: refs/heads/master@{#33579}