print nicer errors for a const dependency graph failure

print nicer errors for a const dependency graph failure

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/001f64b564451802aa95df61440df22118b3f316

[skybrian, 2016-01-22 03:46:04]

skybrian@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[skybrian, 2016-01-22 03:46:05]

The variable renames to "source" are from a failed first attempt. I like the
shorter name better, but can take it out if you prefer.

[Paul Berry, 2016-01-22 15:02:22]

lgtm

https://codereview.chromium.org/1618103002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/constant_test.dart (right):

https://codereview.chromium.org/1618103002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:78: var out = new StringBuffer();
In analyzer code we have made the deliberate choice to use explicit static types
(even though it's against the style guide).  So this should be "StringBuffer out
= new StringBuffer();".

Similar comment applies to "var s" and "var text" below.

(FYI, if you're using IntelliJ, you can do this easily by placing your cursor on
"var" and pressing Alt-Enter)

[Brian Wilkerson, 2016-01-22 15:32:17]

LGTM

https://codereview.chromium.org/1618103002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/constant_test.dart (right):

https://codereview.chromium.org/1618103002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:83: if (text == "") continue;
We also always use blocks in structured statements such as 'if's (and in this
case it would therefore read better to reverse the condition).

[skybrian, 2016-01-22 22:47:21]

Description was changed from

==========
print nicer errors for a const dependency graph failure

BUG=
==========

to

==========
print nicer errors for a const dependency graph failure

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/001f64b564451802aa95df61440df22118b3f316
==========

[skybrian, 2016-01-22 22:47:23]

Committed patchset #1 (id:1) manually as
001f64b564451802aa95df61440df22118b3f316 (presubmit successful).