move constant tests to constant_test.dart

move constant tests to constant_test.dart

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/771fea450212024d60e1498427601fca3b712199

[skybrian, 2016-01-22 02:51:41]

skybrian@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

[Paul Berry, 2016-01-22 14:52:17]

lgtm

[Brian Wilkerson, 2016-01-22 15:17:01]

LGTM

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/constant_test.dart (right):

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:1: // Copyright (c) 2016, the
Dart project authors.  Please see the AUTHORS file
I've been keeping the original copyright when I move code from one file into a
new file. Not sure whether it makes any difference, though.

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:5: library
analyzer.test.generated.all_the_rest_test;
"all_the_rest_test" --> "constant_test" (I'm surprised there wasn't an error in
test_all about importing two libraries with the same name.)

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:2190: class
TestAnalysisContext_ConstantFinderTest extends TestAnalysisContext {
Perhaps rename to something like ConstantFinderTestContext?

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:2191: bool invoked = false;
Looks like dead code.

[skybrian, 2016-01-22 20:44:18]

Description was changed from

==========
move constant tests to constant_test.dart

BUG=
==========

to

==========
move constant tests to constant_test.dart

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/771fea450212024d60e1498427601fca3b712199
==========

[skybrian, 2016-01-22 20:44:19]

Committed patchset #1 (id:1) manually as
771fea450212024d60e1498427601fca3b712199 (presubmit successful).

[skybrian, 2016-01-22 20:46:32]

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/constant_test.dart (right):

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:5: library
analyzer.test.generated.all_the_rest_test;
On 2016/01/22 15:17:01, Brian Wilkerson wrote:
> "all_the_rest_test" --> "constant_test" (I'm surprised there wasn't an error
in
> test_all about importing two libraries with the same name.)

Fixed.

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:2190: class
TestAnalysisContext_ConstantFinderTest extends TestAnalysisContext {
On 2016/01/22 15:17:01, Brian Wilkerson wrote:
> Perhaps rename to something like ConstantFinderTestContext?

Went with _TestAnalysisContext.

https://codereview.chromium.org/1616743006/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/constant_test.dart:2191: bool invoked = false;
On 2016/01/22 15:17:01, Brian Wilkerson wrote:
> Looks like dead code.

Removed.