Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1618063003: Test theory about didCommitProvisionalLoad crash. (Closed)

Created:
4 years, 11 months ago by Charlie Reis
Modified:
4 years, 11 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test theory about didCommitProvisionalLoad crash. It appears that we're creating a RenderView with both a main frame routing ID and a proxy routing ID, which shouldn't be possible after the switch to disable swappedout://. BUG=575245 TEST=Crash in RenderViewImpl::Initialize instead. Committed: https://crrev.com/d03d22651ca68719b472a6489a0ea9fa3170ab4c Cr-Commit-Position: refs/heads/master@{#371009}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
Charlie Reis
https://codereview.chromium.org/1618063003/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/1618063003/diff/1/content/renderer/render_view_impl.cc#newcode694 content/renderer/render_view_impl.cc:694: CHECK(!SiteIsolationPolicy::IsSwappedOutStateForbidden()); I suspect that we'll fail this check rather ...
4 years, 11 months ago (2016-01-22 18:00:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618063003/1
4 years, 11 months ago (2016-01-22 18:20:56 UTC) #4
nasko
LGTM
4 years, 11 months ago (2016-01-22 18:39:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618063003/1
4 years, 11 months ago (2016-01-22 18:41:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 19:36:11 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 19:37:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d03d22651ca68719b472a6489a0ea9fa3170ab4c
Cr-Commit-Position: refs/heads/master@{#371009}

Powered by Google App Engine
This is Rietveld 408576698