Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 1617593004: Use EXPECT instead of DCHECK in traffic_stats_unittest (Closed)

Created:
4 years, 11 months ago by Daniel Imms
Modified:
4 years, 11 months ago
Reviewers:
asanka
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EXPECT instead of DCHECK in traffic_stats_unittest If the unit test is run and the DCHECK fails on an Android device it will crash the browser and report unknown to the test runner for this test and all successive tests, making it difficult to find the failing assertion and failing test. BUG=NONE Committed: https://crrev.com/9ebaf878de33c358b12a7066b811f54f1571c801 Cr-Commit-Position: refs/heads/master@{#370777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/android/traffic_stats_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniel Imms
PTAL
4 years, 11 months ago (2016-01-21 18:18:53 UTC) #2
asanka
lgtm
4 years, 11 months ago (2016-01-21 19:51:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617593004/1
4 years, 11 months ago (2016-01-21 20:04:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 20:38:50 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:41:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ebaf878de33c358b12a7066b811f54f1571c801
Cr-Commit-Position: refs/heads/master@{#370777}

Powered by Google App Engine
This is Rietveld 408576698