Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: net/android/traffic_stats_unittest.cc

Issue 1617593004: Use EXPECT instead of DCHECK in traffic_stats_unittest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/android/traffic_stats_unittest.cc
diff --git a/net/android/traffic_stats_unittest.cc b/net/android/traffic_stats_unittest.cc
index de49ec53d2b1892f013c14d1bcbe6b61b2760a53..29abbe70e39735b35edcc8d1a34221584d2315ed 100644
--- a/net/android/traffic_stats_unittest.cc
+++ b/net/android/traffic_stats_unittest.cc
@@ -42,9 +42,9 @@ TEST(TrafficStatsAndroidTest, BasicsTest) {
int64_t tx_bytes_after_request = -1;
int64_t rx_bytes_after_request = -1;
EXPECT_TRUE(android::traffic_stats::GetTotalTxBytes(&tx_bytes_after_request));
- DCHECK_GT(tx_bytes_after_request, tx_bytes_before_request);
+ EXPECT_GT(tx_bytes_after_request, tx_bytes_before_request);
EXPECT_TRUE(android::traffic_stats::GetTotalRxBytes(&rx_bytes_after_request));
- DCHECK_GT(rx_bytes_after_request, rx_bytes_before_request);
+ EXPECT_GT(rx_bytes_after_request, rx_bytes_before_request);
}
TEST(TrafficStatsAndroidTest, UIDBasicsTest) {
@@ -76,10 +76,10 @@ TEST(TrafficStatsAndroidTest, UIDBasicsTest) {
int64_t rx_bytes_after_request = -1;
EXPECT_TRUE(
android::traffic_stats::GetCurrentUidTxBytes(&tx_bytes_after_request));
- DCHECK_GT(tx_bytes_after_request, tx_bytes_before_request);
+ EXPECT_GT(tx_bytes_after_request, tx_bytes_before_request);
EXPECT_TRUE(
android::traffic_stats::GetCurrentUidRxBytes(&rx_bytes_after_request));
- DCHECK_GT(rx_bytes_after_request, rx_bytes_before_request);
+ EXPECT_GT(rx_bytes_after_request, rx_bytes_before_request);
}
} // namespace
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698