Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16175003: google_apis: Rename OperationRunner to RequestSender (Closed)

Created:
7 years, 6 months ago by satorux1
Modified:
7 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

google_apis: Rename OperationRunner to RequestSender OperatinRunner is rather a misnomer as this class is used to send HTTP requests, hence RequestSender. BUG=240599 TEST=none R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204425

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -552 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/contacts/gdata_contacts_service.cc View 11 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/google_apis/base_requests.h View 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/google_apis/base_requests.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/google_apis/base_requests_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations.h View 17 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations.cc View 17 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations_unittest.cc View 34 chunks +40 lines, -40 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 29 chunks +62 lines, -62 lines 0 comments Download
M chrome/browser/google_apis/gdata_contacts_operations.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/gdata_contacts_operations.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.h View 15 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 35 chunks +38 lines, -38 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 27 chunks +59 lines, -59 lines 0 comments Download
D chrome/browser/google_apis/operation_runner.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/google_apis/operation_runner.cc View 1 chunk +0 lines, -90 lines 0 comments Download
A + chrome/browser/google_apis/request_sender.h View 5 chunks +22 lines, -22 lines 0 comments Download
A + chrome/browser/google_apis/request_sender.cc View 3 chunks +22 lines, -22 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
one rename patch a day
7 years, 6 months ago (2013-06-06 04:14:56 UTC) #1
kinaba
lgtm. The days of rebasing are coming...
7 years, 6 months ago (2013-06-06 04:19:03 UTC) #2
satorux1
7 years, 6 months ago (2013-06-06 04:55:05 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r204425 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698