Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 161733002: add peekPixels to SkCanvas and SkSurface (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add peekPixels to SkCanvas and SkSurface clone of https://codereview.chromium.org/159723006/ Committed: https://code.google.com/p/skia/source/detail?r=13427

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -303 lines) Patch
M gm/aaclip.cpp View 1 2 3 4 5 3 chunks +5 lines, -214 lines 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M gm/bitmapsource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/deviceproperties.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/displacement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/gammatext.cpp View 2 chunks +14 lines, -6 lines 0 comments Download
M gm/gm.h View 1 chunk +1 line, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/lighting.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/morphology.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/offsetimagefilter.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
A gm/peekpixels.cpp View 1 2 3 4 5 6 1 chunk +78 lines, -0 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +7 lines, -0 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 5 chunks +73 lines, -4 lines 0 comments Download
M include/core/SkDevice.h View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M include/core/SkSurface.h View 1 chunk +12 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M samplecode/SampleCircle.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 4 5 6 7 1 chunk +49 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImagePriv.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 1 2 3 4 5 6 7 1 chunk +5 lines, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 2 3 4 5 6 7 4 chunks +81 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Committed patchset #8 manually as r13427.
6 years, 10 months ago (2014-02-13 15:11:31 UTC) #1
reed2
A revert of this CL has been created in https://codereview.chromium.org/163823002/ by reed@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-13 15:21:39 UTC) #2
reed1
6 years, 10 months ago (2014-02-13 15:29:34 UTC) #3
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/163493005/ by reed@google.com.

The reason for reverting is: xfermodes3 gm failed to compile.

Powered by Google App Engine
This is Rietveld 408576698