Putting the feedback section of the block interstitial to the correct place based on the mocks.

Putting the feedback section of the block interstitial to the correct place based on the mocks.
Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671
Committed: https://crrev.com/2af7a0e077c9cff0ac114d769eca3f924d176d6a
Cr-Commit-Position: refs/heads/master@{#372101}

[atanasova, 2016-01-21 23:35:22]

Description was changed from

==========
Putting the feedback section of the block interstitial to the correct place
based on the mocks.
Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671
==========

to

==========
Putting the feedback section of the block interstitial to the correct place
based on the mocks.
Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671
==========

[atanasova, 2016-01-21 23:35:22]

atanasova@chromium.org changed reviewers:
+ treib@chromium.org

[atanasova, 2016-01-21 23:36:18]

Hi Marc!
Since I don't yet have an update on the "Learn more" link I decided to go
through with this part that fixes the position and style of the feedback button.
Later one once we have the learn more information, I will create another CL.

[Marc Treib, 2016-01-22 00:35:52]

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_block_interstitial.css (right):

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_block_interstitial.css:41: color:
rgb(66, 133, 244);
I guess the mocks use a slightly different color from the default link blue? :-/

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_block_interstitial.html (right):

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_block_interstitial.html:55: <h1>
Remove the empty h1

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_block_interstitial.js (right):

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_block_interstitial.js:75:
$('feedback').hidden = true;
I guess this is now technically not required anymore, since it's empty in this
case anyway?

[atanasova, 2016-01-22 19:32:24]

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_block_interstitial.css (right):

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_block_interstitial.css:41: color:
rgb(66, 133, 244);
On 2016/01/22 00:35:52, Marc Treib wrote:
> I guess the mocks use a slightly different color from the default link blue?
:-/

Yes, it uses the same blue that the button does, the default link color I think
is just blue (it looks different).

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_block_interstitial.html (right):

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_block_interstitial.html:55: <h1>
On 2016/01/22 00:35:52, Marc Treib wrote:
> Remove the empty h1

Done.

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
File chrome/browser/resources/supervised_user_block_interstitial.js (right):

https://codereview.chromium.org/1617293002/diff/1/chrome/browser/resources/su...
chrome/browser/resources/supervised_user_block_interstitial.js:75:
$('feedback').hidden = true;
On 2016/01/22 00:35:52, Marc Treib wrote:
> I guess this is now technically not required anymore, since it's empty in this
> case anyway?

Done.

[Marc Treib, 2016-01-25 09:40:56]

LGTM

I'm not a fan of .innerHTML and putting HTML into strings, but I don't know of a
better way to do it :(

[atanasova, 2016-01-28 08:36:51]

atanasova@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-01-28 10:37:40]

On 2016/01/25 09:40:56, Marc Treib wrote:
> LGTM
> 
> I'm not a fan of .innerHTML and putting HTML into strings, but I don't know of
a
> better way to do it :(

Yeah, there isn't really a better way right now, but I do come across this
pretty regularly, so I put my thoughts on how I would like this to work into a
bug at crbug.com/582017.

https://codereview.chromium.org/1617293002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/supervised_user_block_interstitial.html (right):

https://codereview.chromium.org/1617293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/supervised_user_block_interstitial.html:58: <p
id="feedback"></p>
You could do this with i18n-values=".innerHTML:feedbackLink", so at least it's
close to the other messages.

[atanasova, 2016-01-28 13:53:34]

https://codereview.chromium.org/1617293002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/supervised_user_block_interstitial.html (right):

https://codereview.chromium.org/1617293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/supervised_user_block_interstitial.html:58: <p
id="feedback"></p>
On 2016/01/28 10:37:40, Bernhard Bauer wrote:
> You could do this with i18n-values=".innerHTML:feedbackLink", so at least it's
> close to the other messages.

Done.

[Bernhard Bauer, 2016-01-28 14:00:42]

https://codereview.chromium.org/1617293002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/supervised_user_block_interstitial.js (right):

https://codereview.chromium.org/1617293002/diff/40001/chrome/browser/resource...
chrome/browser/resources/supervised_user_block_interstitial.js:75:
$('feedback').hidden = true;
Actually, do we need this if the link starts out as hidden? Alternatively, we
could do it the other way around, then the only change necessary here would be
from .style.display to .hidden.

[atanasova, 2016-01-28 14:32:57]

https://codereview.chromium.org/1617293002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/supervised_user_block_interstitial.js (right):

https://codereview.chromium.org/1617293002/diff/40001/chrome/browser/resource...
chrome/browser/resources/supervised_user_block_interstitial.js:75:
$('feedback').hidden = true;
On 2016/01/28 14:00:42, Bernhard Bauer wrote:
> Actually, do we need this if the link starts out as hidden? Alternatively, we
> could do it the other way around, then the only change necessary here would be
> from .style.display to .hidden.

I went with the second suggestion, trying to keep the logic similar to what we
had before.

[Bernhard Bauer, 2016-01-28 14:33:36]

LGTM!

[atanasova, 2016-01-28 14:33:56]

The CQ bit was checked by atanasova@chromium.org

[atanasova, 2016-01-28 14:33:56]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/1617293002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-28 14:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1617293002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1617293002/60001

[commit-bot: I haz the power, 2016-01-28 16:35:38]

Description was changed from

==========
Putting the feedback section of the block interstitial to the correct place
based on the mocks.
Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671
==========

to

==========
Putting the feedback section of the block interstitial to the correct place
based on the mocks.
Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671
==========

[commit-bot: I haz the power, 2016-01-28 16:35:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 16:36:54]

Description was changed from

==========
Putting the feedback section of the block interstitial to the correct place
based on the mocks.
Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671
==========

to

==========
Putting the feedback section of the block interstitial to the correct place
based on the mocks.
Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671

Committed: https://crrev.com/2af7a0e077c9cff0ac114d769eca3f924d176d6a
Cr-Commit-Position: refs/heads/master@{#372101}
==========

[commit-bot: I haz the power, 2016-01-28 16:36:54]

Patchset 4 (id:??) landed as
https://crrev.com/2af7a0e077c9cff0ac114d769eca3f924d176d6a
Cr-Commit-Position: refs/heads/master@{#372101}