chrome/browser/resources/supervised_user_block_interstitial.html - Issue 1617293002: Putting the feedback section of the block interstitial to the correct place based on the mocks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/supervised_user_block_interstitial.html

Issue 1617293002: Putting the feedback section of the block interstitial to the correct place based on the mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Marc's comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/supervised_user_block_interstitial.css ('k') | chrome/browser/resources/supervised_user_block_interstitial.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html i18n-values="dir:textdirection;lang:language">

3 <head>	3 <head>

4 <meta name="viewport" content="width=device-width">	4 <meta name="viewport" content="width=device-width">

5 <meta charset="utf-8">	5 <meta charset="utf-8">

6 <title i18n-content="blockPageTitle"></title>	6 <title i18n-content="blockPageTitle"></title>

7 <link rel="stylesheet" href="../../../ui/webui/resources/css/widgets.css">	7 <link rel="stylesheet" href="../../../ui/webui/resources/css/widgets.css">

8 <link rel="stylesheet" href="supervised_user_block_interstitial.css">	8 <link rel="stylesheet" href="supervised_user_block_interstitial.css">

9 <script src="../../../ui/webui/resources/js/cr.js"></script>	9 <script src="../../../ui/webui/resources/js/cr.js"></script>

10 <script src="../../../ui/webui/resources/js/util.js"></script>	10 <script src="../../../ui/webui/resources/js/util.js"></script>

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 </a>	45 </a>

46 <a id="hide-details-link" i18n-content="hideDetailsLink"	46 <a id="hide-details-link" i18n-content="hideDetailsLink"

47 hidden class="button"></a>	47 hidden class="button"></a>

48 <a id="back-button" i18n-content="backButton"	48 <a id="back-button" i18n-content="backButton"

49 hidden class="button"></a>	49 hidden class="button"></a>

50 </div>	50 </div>

51 <div id="request-access-button" class="button"	51 <div id="request-access-button" class="button"

52 i18n-content="requestAccessButton">	52 i18n-content="requestAccessButton">

53 </div>	53 </div>

54 </div>	54 </div>

55 <h1>

56 <a id="feedback-link" is="action-link" i18n-content="feedbackLink"></a>

57 </h1>

58 <div id="details" hidden>	55 <div id="details" hidden>

59 <p id="details-header" i18n-content="blockReasonHeader"></p>	56 <p id="details-header" i18n-content="blockReasonHeader"></p>

60 <p id="details-message" i18n-content="blockReasonMessage"></p>	57 <p id="details-message" i18n-content="blockReasonMessage"></p>

	58 <p id="feedback"></p>
	Bernhard Bauer 2016/01/28 10:37:40 You could do this with i18n-values=".innerHTML:fee You could do this with i18n-values=".innerHTML:feedbackLink", so at least it's close to the other messages. atanasova 2016/01/28 13:53:34 Done. Show quoted text On 2016/01/28 10:37:40, Bernhard Bauer wrote: > You could do this with i18n-values=".innerHTML:feedbackLink", so at least it's > close to the other messages. Done.
61 </div>	59 </div>

62 </div>	60 </div>

63 </body>	61 </body>

64 </html>	62 </html>

OLD	NEW