Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1617253002: rewrite_to_chrome_style: exclude conversion functions from being renamed (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: exclude conversion functions from being renamed BUG=578344 Committed: https://crrev.com/387a1d91ab2629f483da15d3aaffa103fd12811e Cr-Commit-Position: refs/heads/master@{#370802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc View 1 chunk +6 lines, -1 line 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/methods-original.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
Whee
4 years, 11 months ago (2016-01-21 21:42:29 UTC) #2
danakj
LGTM
4 years, 11 months ago (2016-01-21 21:43:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617253002/1
4 years, 11 months ago (2016-01-21 21:46:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 22:08:58 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 22:10:33 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/387a1d91ab2629f483da15d3aaffa103fd12811e
Cr-Commit-Position: refs/heads/master@{#370802}

Powered by Google App Engine
This is Rietveld 408576698