Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 1617253002: rewrite_to_chrome_style: exclude conversion functions from being renamed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index fcbd9216513a5e389a9e0ed3e1c926ebbf2c01af..78df7a35440638fd7cada77ecc3919c48000fcec 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -432,9 +432,11 @@ int main(int argc, const char* argv[]) {
// Overloaded operators have special names
// and should never be renamed.
isOverloadedOperator(),
- // Similarly, constructors and destructors
- // should not be considered for renaming.
- cxxConstructorDecl(), cxxDestructorDecl())),
+ // Similarly, constructors, destructors, and
+ // conversion functions should not be
+ // considered for renaming.
+ cxxConstructorDecl(), cxxDestructorDecl(),
+ cxxConversionDecl())),
in_blink_namespace));
// Note that the matcher for overridden methods doesn't need to filter for
// special member functions: see implementation of FunctionDeclRewriter for
« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698