Issue 16172006: Center wide new-style Views JavaScript dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16172006: Center wide new-style Views JavaScript dialogs. (Closed)

Created:
7 years, 6 months ago by msw

Modified:
7 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Center wide new-style Views JavaScript dialogs. New-style dialogs accommodate long titles (unlike old style). Horizontally center JS dialogs with long domain titles. See before/after pics at http://crbug.com/242284#c17 BUG=242284, 166075 TEST=javascript:alert("Hello") from a long domain, like http://www.thelongestlistofthelongeststuffatthelongestdomainnameatlonglast.com/ R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203240

Patch Set 1 #

Patch Set 2 : Add a parent_window NULL check. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	chrome/browser/ui/views/javascript_app_modal_dialog_views.cc	View	1	1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/16172006/1

7 years, 6 months ago (2013-05-30 17:17:48 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=45386

7 years, 6 months ago (2013-05-30 19:26:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/16172006/26001

7 years, 6 months ago (2013-05-30 19:37:46 UTC) #5

Message was sent while issue was closed.

Change committed as 203240

Expand Messages | Collapse Messages