Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 16171010: Introduces a new scrollbar for message_center. (Closed)

Created:
7 years, 6 months ago by Jun Mukai
Modified:
7 years, 6 months ago
Reviewers:
sadrul, dewittj
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Introduces a new scrollbar for message_center. The new one overlaps with the scroll contents. BUG=239559 R=sadrul@chromium.org, dewittj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204146

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : GetVisibleSize -> GetContentOverlapSize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -8 lines) Patch
M ui/message_center/views/message_center_view.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/scroll_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 2 3 3 chunks +22 lines, -4 lines 0 comments Download
A ui/views/controls/scrollbar/overlay_scroll_bar.h View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A ui/views/controls/scrollbar/overlay_scroll_bar.cc View 1 2 3 1 chunk +148 lines, -0 lines 0 comments Download
M ui/views/controls/scrollbar/scroll_bar.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/controls/scrollbar/scroll_bar.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
7 years, 6 months ago (2013-05-30 21:13:09 UTC) #1
dewittj
message_center lgtm
7 years, 6 months ago (2013-05-31 16:43:00 UTC) #2
Jun Mukai
sadrul, could you take some time to review this? or should I ask someone else ...
7 years, 6 months ago (2013-06-03 20:05:56 UTC) #3
sadrul
LGTM https://codereview.chromium.org/16171010/diff/4001/ui/views/controls/scrollbar/scroll_bar.h File ui/views/controls/scrollbar/scroll_bar.h (right): https://codereview.chromium.org/16171010/diff/4001/ui/views/controls/scrollbar/scroll_bar.h#newcode92 ui/views/controls/scrollbar/scroll_bar.h:92: virtual int GetVisibleSize() const; Call this GetContentOverlapSize() instead. ...
7 years, 6 months ago (2013-06-04 19:03:24 UTC) #4
Jun Mukai
https://codereview.chromium.org/16171010/diff/4001/ui/views/controls/scrollbar/scroll_bar.h File ui/views/controls/scrollbar/scroll_bar.h (right): https://codereview.chromium.org/16171010/diff/4001/ui/views/controls/scrollbar/scroll_bar.h#newcode92 ui/views/controls/scrollbar/scroll_bar.h:92: virtual int GetVisibleSize() const; On 2013/06/04 19:03:24, sadrul wrote: ...
7 years, 6 months ago (2013-06-04 20:52:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/16171010/11001
7 years, 6 months ago (2013-06-04 20:52:50 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 03:37:18 UTC) #7
Message was sent while issue was closed.
Change committed as 204146

Powered by Google App Engine
This is Rietveld 408576698