Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1616743004: Revert of Enable crash symbols unit test for Mac OSX. (Closed)

Created:
4 years, 11 months ago by tsergeant
Modified:
4 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable crash symbols unit test for Mac OSX. (patchset #4 id:60001 of https://codereview.chromium.org/1586143003/ ) Reason for revert: This patch appears to be causing failures in telemetry_perf_unittests on Mac-10.9: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/18194 Original issue's description: > Enable crash symbols unit test for Mac OSX. > > R=nednguyen@google.com > BUG=563716 > > Committed: https://crrev.com/7dfa2f79c2fda175f1202cac8d5a51d1e64a2171 > Cr-Commit-Position: refs/heads/master@{#370745} TBR=nednguyen@google.com,avi@chromium.org,dyen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563716 Committed: https://crrev.com/be50aafa27c1ebcc4a292ea415c74c75279b4961 Cr-Commit-Position: refs/heads/master@{#370814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M tools/perf/core/stacktrace_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tsergeant
Created Revert of Enable crash symbols unit test for Mac OSX.
4 years, 11 months ago (2016-01-21 23:00:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616743004/1
4 years, 11 months ago (2016-01-21 23:03:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 23:05:58 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 23:06:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be50aafa27c1ebcc4a292ea415c74c75279b4961
Cr-Commit-Position: refs/heads/master@{#370814}

Powered by Google App Engine
This is Rietveld 408576698