tools/perf/core/stacktrace_unittest.py - Issue 1616743004: Revert of Enable crash symbols unit test for Mac OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/core/stacktrace_unittest.py

Issue 1616743004: Revert of Enable crash symbols unit test for Mac OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/core/stacktrace_unittest.py

diff --git a/tools/perf/core/stacktrace_unittest.py b/tools/perf/core/stacktrace_unittest.py

index bc70dee02b51135da77323224b638dc75e05c20f..ae4e55b9d4f628f663bf607939700ddc1c211554 100644

--- a/tools/perf/core/stacktrace_unittest.py

+++ b/tools/perf/core/stacktrace_unittest.py

@@ -20,9 +20,9 @@

self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace))

# Currently stack traces do not work on windows: http://crbug.com/476110

+ # Currently symbols do not work on swarming: http://crbug.com/563716

# Linux stack traces depends on fission support: http://crbug.com/405623

- @decorators.Enabled('mac')

- @decorators.Disabled('snowleopard')

+ @decorators.Disabled('all')

def testCrashSymbols(self):

try:

self._tab.Navigate('chrome://crash', timeout=5)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py » ('j') | no next file with comments »