Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1616553002: Update VS 2013 package to support Win10 10586 SDK (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, penny, Sébastien Marchand
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update VS 2013 package to support Win10 10586 SDK This also incorporates other fixes such as crrev.com/1608373002 and crrev.com/1609933004. This is needed to allow building crrev.com/1626623003 with VS 2013. Committed: https://crrev.com/adb68ba6a3698c049d1185ec507674aa509bbb00 Cr-Commit-Position: refs/heads/master@{#373026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
brucedawson
pennymac@'s change (see description) needs the 10586 SDK and I haven't landed VS 2015 yet. ...
4 years, 10 months ago (2016-02-02 19:27:49 UTC) #3
scottmg
rs lgtm
4 years, 10 months ago (2016-02-02 19:38:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616553002/1
4 years, 10 months ago (2016-02-02 20:14:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 20:50:01 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 20:51:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adb68ba6a3698c049d1185ec507674aa509bbb00
Cr-Commit-Position: refs/heads/master@{#373026}

Powered by Google App Engine
This is Rietveld 408576698