Merged addProlog and addEpilog on x86.

Merged addProlog and addEpilog on x86.

BUG=
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b9a404d433ca20a86ea2398555ecb48ba2cba3b5

[sehr, 2016-01-21 00:36:07]

Description was changed from

==========
Merged addProlog and addEpilog on x86.

BUG=
==========

to

==========
Merged addProlog and addEpilog on x86.

BUG=
==========

[sehr, 2016-01-21 00:36:07]

sehr@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[sehr, 2016-01-21 00:36:18]

PTAL.

[John, 2016-01-21 15:04:52]

lgtm

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX8664.cpp
File src/IceTargetLoweringX8664.cpp (right):

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX8664....
src/IceTargetLoweringX8664.cpp:407: Variable *rsp =
getPhysicalRegister(getStackReg(), Traits::WordType);
why? just curious...

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Base.h
File src/IceTargetLoweringX86Base.h (right):

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Bas...
src/IceTargetLoweringX86Base.h:291: virtual void emitSandboxedReturn() {
is virtual needed here?

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Bas...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Bas...
src/IceTargetLoweringX86BaseImpl.h:1011: if (!Traits::X86_PASS_SCALAR_FP_IN_XMM
&& isScalarFloatingType(ReturnType)) {
optional: I personally prefer

if (!Traits:BLAH) {
  if (...) {
  }
}

because then I know the nested code is BLAH-specific.

[sehr, 2016-01-21 16:02:11]

Thanks for the review.  Testing before commit...

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX8664.cpp
File src/IceTargetLoweringX8664.cpp (right):

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX8664....
src/IceTargetLoweringX8664.cpp:407: Variable *rsp =
getPhysicalRegister(getStackReg(), Traits::WordType);
On 2016/01/21 15:04:52, John wrote:
> why? just curious...

I honestly think semantically referring to this as the stack register rather
than a specific name conveys some value, but I've reverted the change as it's
purely aesthetic.

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Base.h
File src/IceTargetLoweringX86Base.h (right):

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Bas...
src/IceTargetLoweringX86Base.h:291: virtual void emitSandboxedReturn() {
On 2016/01/21 15:04:52, John wrote:
> is virtual needed here?

Removed.

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Bas...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1616483003/diff/1/src/IceTargetLoweringX86Bas...
src/IceTargetLoweringX86BaseImpl.h:1011: if (!Traits::X86_PASS_SCALAR_FP_IN_XMM
&& isScalarFloatingType(ReturnType)) {
On 2016/01/21 15:04:52, John wrote:
> optional: I personally prefer
> 
> if (!Traits:BLAH) {
>   if (...) {
>   }
> }
> 
> because then I know the nested code is BLAH-specific.

Kernighan's "Elements of Programming Style" teaches to avoid deep if-nests when
possible.  But style consistency prevails.  Changed.

[sehr, 2016-01-21 16:09:30]

Description was changed from

==========
Merged addProlog and addEpilog on x86.

BUG=
==========

to

==========
Merged addProlog and addEpilog on x86.

BUG=
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[sehr, 2016-01-21 16:09:31]

Committed patchset #1 (id:1) manually as
b9a404d433ca20a86ea2398555ecb48ba2cba3b5 (tree was closed).