third_party/WebKit/Source/core/css/CSSPageRule.cpp - Issue 1616423003: Fix selector namespace prefix resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPageRule.cpp

Issue 1616423003: Fix selector namespace prefix resolution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected correction Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPageRule.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPageRule.cpp b/third_party/WebKit/Source/core/css/CSSPageRule.cpp

index e608db82f6eb06b4ebaeb87abd627f6a3660288d..2443b3d3f142f22f19c5ad01dca85d4a6d954413 100644

--- a/third_party/WebKit/Source/core/css/CSSPageRule.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPageRule.cpp

@@ -70,7 +70,7 @@ String CSSPageRule::selectorText() const

void CSSPageRule::setSelectorText(const String& selectorText)

{

CSSParserContext context(parserContext(), 0);

- CSSSelectorList selectorList = CSSParser::parseSelector(context, selectorText);

+ CSSSelectorList selectorList = CSSParser::parseSelector(context, parentStyleSheet()->contents(), selectorText);

Timothy Loh 2016/01/25 00:30:47 OK, but I wonder if this function is completely wr

rune 2016/01/25 08:58:48 Reported https://crbug.com/580956

if (!selectorList.isValid())

return;