third_party/WebKit/Source/core/css/CSSPageRule.cpp - Issue 1616423003: Fix selector namespace prefix resolution.

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPageRule.cpp

Issue 1616423003: Fix selector namespace prefix resolution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected correction Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/content-selector-query-expected.txt ('k') | third_party/WebKit/Source/core/css/CSSSelectorList.h » ('j') | third_party/WebKit/Source/core/css/CSSStyleRule.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)	2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)

3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)	3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)

4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.	4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 text.append(' ');	63 text.append(' ');

64 text.append(pageSpecification);	64 text.append(pageSpecification);

65 }	65 }

66 }	66 }

67 return text.toString();	67 return text.toString();

68 }	68 }

69	69

70 void CSSPageRule::setSelectorText(const String& selectorText)	70 void CSSPageRule::setSelectorText(const String& selectorText)

71 {	71 {

72 CSSParserContext context(parserContext(), 0);	72 CSSParserContext context(parserContext(), 0);

73 CSSSelectorList selectorList = CSSParser::parseSelector(context, selectorTex t);	73 CSSSelectorList selectorList = CSSParser::parseSelector(context, parentStyle Sheet()->contents(), selectorText);
	Timothy Loh 2016/01/25 00:30:47 OK, but I wonder if this function is completely wr OK, but I wonder if this function is completely wrong, CSSParserImpl::consumePageRule just does it's own thing. rune 2016/01/25 08:58:48 Reported https://crbug.com/580956 Show quoted text On 2016/01/25 00:30:47, Timothy Loh wrote: > OK, but I wonder if this function is completely wrong, > CSSParserImpl::consumePageRule just does it's own thing. Reported https://crbug.com/580956
74 if (!selectorList.isValid())	74 if (!selectorList.isValid())

75 return;	75 return;

76	76

77 CSSStyleSheet::RuleMutationScope mutationScope(this);	77 CSSStyleSheet::RuleMutationScope mutationScope(this);

78	78

79 m_pageRule->wrapperAdoptSelectorList(std::move(selectorList));	79 m_pageRule->wrapperAdoptSelectorList(std::move(selectorList));

80 }	80 }

81	81

82 String CSSPageRule::cssText() const	82 String CSSPageRule::cssText() const

83 {	83 {

(...skipping 17 matching lines...) Expand all Loading...
101 }	101 }

102	102

103 DEFINE_TRACE(CSSPageRule)	103 DEFINE_TRACE(CSSPageRule)

104 {	104 {

105 visitor->trace(m_pageRule);	105 visitor->trace(m_pageRule);

106 visitor->trace(m_propertiesCSSOMWrapper);	106 visitor->trace(m_propertiesCSSOMWrapper);

107 CSSRule::trace(visitor);	107 CSSRule::trace(visitor);

108 }	108 }

109	109

110 } // namespace blink	110 } // namespace blink

OLD	NEW