Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1616043004: Remove deprecated cruft from SelectPopupDialog. (Closed)

Created:
4 years, 11 months ago by newt (away)
Modified:
4 years, 11 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated cruft from SelectPopupDialog. This removes two bits of unneeded, no-op code from SelectPopupDialog, one of which was causing a deprecation warning (AlertDialog.Builder.setInverseBackgroundForced()). Committed: https://crrev.com/6aa5052dfabac4261f62021b95fd966de9e8e05e Cr-Commit-Position: refs/heads/master@{#371286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
newt (away)
PTAL
4 years, 11 months ago (2016-01-22 23:41:40 UTC) #3
newt (away)
Note: cacheColorHint is useless unless you pass in an actual color (which we used to ...
4 years, 11 months ago (2016-01-22 23:43:27 UTC) #4
Yaron
lgtm
4 years, 11 months ago (2016-01-25 15:03:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616043004/1
4 years, 11 months ago (2016-01-25 18:16:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 19:44:17 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 19:54:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6aa5052dfabac4261f62021b95fd966de9e8e05e
Cr-Commit-Position: refs/heads/master@{#371286}

Powered by Google App Engine
This is Rietveld 408576698