content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java - Issue 1616043004: Remove deprecated cruft from SelectPopupDialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

Issue 1616043004: Remove deprecated cruft from SelectPopupDialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

index fc5f38d1ec251cf038c923a78b585a295518cd3b..f14b93aaff2eb259d758786021afe78db1de9637 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

@@ -40,11 +40,9 @@ public class SelectPopupDialog implements SelectPopup {

mContentViewCore = contentViewCore;

final ListView listView = new ListView(windowContext);

- listView.setCacheColorHint(0);

AlertDialog.Builder b = new AlertDialog.Builder(windowContext)

.setView(listView)

- .setCancelable(true)

- .setInverseBackgroundForced(true);

+ .setCancelable(true);

if (multiple) {

b.setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »