piman: can you take a look? Patch set 1 is exactly the same as the ...
4 years, 11 months ago
(2016-01-21 22:12:29 UTC)
#2
piman: can you take a look?
Patch set 1 is exactly the same as the reviewed/landed/reverted CL:
https://codereview.chromium.org/1605323004/
Patch set 2 (feature_info.cc) is where the new changes are.
Testes, this fixed the two failing canvas layout tests.
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616043002/20001
4 years, 11 months ago
(2016-01-21 22:12:43 UTC)
#3
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/137840)
4 years, 11 months ago
(2016-01-21 22:22:45 UTC)
#5
4 years, 11 months ago
(2016-01-21 23:00:35 UTC)
#6
lgtm
Zhenyao Mo
Description was changed from ========== [Reland] Check if internal_format is valid for GenerateMipmap(). BUG=429053 TEST=gpu_unittests,webgl2_conformance ...
4 years, 11 months ago
(2016-01-21 23:10:03 UTC)
#7
Description was changed from
==========
[Reland] Check if internal_format is valid for GenerateMipmap().
BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
==========
to
==========
[Reland] Check if internal_format is valid for GenerateMipmap().
BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
NOPRESUBMIT=true
==========
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
4 years, 11 months ago
(2016-01-22 00:06:19 UTC)
#8
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616043002/20001
4 years, 11 months ago
(2016-01-22 00:07:04 UTC)
#9
Description was changed from ========== [Reland] Check if internal_format is valid for GenerateMipmap(). BUG=429053 TEST=gpu_unittests,webgl2_conformance ...
4 years, 11 months ago
(2016-01-22 00:09:04 UTC)
#10
Message was sent while issue was closed.
Description was changed from
==========
[Reland] Check if internal_format is valid for GenerateMipmap().
BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
NOPRESUBMIT=true
==========
to
==========
[Reland] Check if internal_format is valid for GenerateMipmap().
BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
NOPRESUBMIT=true
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago
(2016-01-22 00:09:04 UTC)
#11
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
commit-bot: I haz the power
Description was changed from ========== [Reland] Check if internal_format is valid for GenerateMipmap(). BUG=429053 TEST=gpu_unittests,webgl2_conformance ...
4 years, 11 months ago
(2016-01-22 00:10:53 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
[Reland] Check if internal_format is valid for GenerateMipmap().
BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
NOPRESUBMIT=true
==========
to
==========
[Reland] Check if internal_format is valid for GenerateMipmap().
BUG=429053
TEST=gpu_unittests,webgl2_conformance
R=piman@chromium.org
NOPRESUBMIT=true
Committed: https://crrev.com/494a77059cf199de5a6e11912fce2a155c868a26
Cr-Commit-Position: refs/heads/master@{#370841}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/494a77059cf199de5a6e11912fce2a155c868a26 Cr-Commit-Position: refs/heads/master@{#370841}
4 years, 11 months ago
(2016-01-22 00:10:54 UTC)
#13
Issue 1616043002: [Reland] Check if internal_format is valid for GenerateMipmap().
(Closed)
Created 4 years, 11 months ago by Zhenyao Mo
Modified 4 years, 11 months ago
Reviewers: piman
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0