Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1616043002: [Reland] Check if internal_format is valid for GenerateMipmap(). (Closed)

Created:
4 years, 11 months ago by Zhenyao Mo
Modified:
4 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Check if internal_format is valid for GenerateMipmap(). BUG=429053 TEST=gpu_unittests,webgl2_conformance R=piman@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/494a77059cf199de5a6e11912fce2a155c868a26 Cr-Commit-Position: refs/heads/master@{#370841}

Patch Set 1 #

Patch Set 2 : add extension behaviors for validators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -36 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +68 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +76 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 7 chunks +35 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 3 chunks +34 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 2 chunks +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 5 chunks +25 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 11 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Zhenyao Mo
piman: can you take a look? Patch set 1 is exactly the same as the ...
4 years, 11 months ago (2016-01-21 22:12:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616043002/20001
4 years, 11 months ago (2016-01-21 22:12:43 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/137840)
4 years, 11 months ago (2016-01-21 22:22:45 UTC) #5
piman
lgtm
4 years, 11 months ago (2016-01-21 23:00:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616043002/20001
4 years, 11 months ago (2016-01-22 00:07:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 00:09:04 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 00:10:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/494a77059cf199de5a6e11912fce2a155c868a26
Cr-Commit-Position: refs/heads/master@{#370841}

Powered by Google App Engine
This is Rietveld 408576698