Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: gpu/command_buffer/service/texture_manager.h

Issue 1616043002: [Reland] Check if internal_format is valid for GenerateMipmap(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add extension behaviors for validators Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/texture_manager.h
diff --git a/gpu/command_buffer/service/texture_manager.h b/gpu/command_buffer/service/texture_manager.h
index e106b735537a93fa6bb61c8e9dbc77ccb4ef0f2f..e33df33059c682db9fe944bcb90ca76aaa834838 100644
--- a/gpu/command_buffer/service/texture_manager.h
+++ b/gpu/command_buffer/service/texture_manager.h
@@ -344,7 +344,7 @@ class GPU_EXPORT Texture {
const FeatureInfo* feature_info, GLenum pname, GLfloat param);
// Makes each of the mip levels as though they were generated.
- bool MarkMipmapsGenerated(const FeatureInfo* feature_info);
+ void MarkMipmapsGenerated(const FeatureInfo* feature_info);
bool NeedsMips() const {
return min_filter_ != GL_NEAREST && min_filter_ != GL_LINEAR;
@@ -756,8 +756,7 @@ class GPU_EXPORT TextureManager : public base::trace_event::MemoryDumpProvider {
TextureRef* ref, GLenum pname, GLfloat param);
// Makes each of the mip levels as though they were generated.
- // Returns false if that's not allowed for the given texture.
- bool MarkMipmapsGenerated(TextureRef* ref);
+ void MarkMipmapsGenerated(TextureRef* ref);
// Clears any uncleared renderable levels.
bool ClearRenderableLevels(GLES2Decoder* decoder, TextureRef* ref);

Powered by Google App Engine
This is Rietveld 408576698