Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 16160006: Revert 202620 "Collect tab timing information for use in telemen..." (Closed)

Created:
7 years, 6 months ago by ramant (doing other things)
Modified:
7 years, 6 months ago
Reviewers:
jeremy
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202620 "Collect tab timing information for use in telemen..." > Collect tab timing information for use in telementry-based startup tests > > Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry. > > Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController. > > Add a new --enable-stats-collection-bindings to activate said object. > > Example usage in telemtry: > with browser.Create() as b: > b.tabs[0].Navigate("http://www.google.com") > b.tabs[0].WaitForDocumentReadyStateToBeComplete() > print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()') > > BUG=None > > Review URL: https://chromiumcodereview.appspot.com/12389073 TBR=jeremy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -355 lines) Patch
M trunk/src/chrome/test/perf/page_cycler_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
MM trunk/src/chrome/test/ui/ui_test.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/test/ui/ui_test.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/histogram_message_filter.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/content_renderer.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/common/bindings_policy.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M trunk/src/content/renderer/dom_automation_controller.h View 1 chunk +9 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/dom_automation_controller.cc View 2 chunks +42 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.h View 4 chunks +2 lines, -16 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 4 chunks +0 lines, -16 lines 0 comments Download
D trunk/src/content/renderer/stats_collection_controller.h View 1 chunk +0 lines, -43 lines 0 comments Download
D trunk/src/content/renderer/stats_collection_controller.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D trunk/src/content/renderer/stats_collection_observer.h View 1 chunk +0 lines, -40 lines 0 comments Download
D trunk/src/content/renderer/stats_collection_observer.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M trunk/src/tools/perf/perf_tools/histogram_metric.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/tools/perf/perf_tools/memory_measurement.py View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/tools/perf/perf_tools/page_cycler.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/tools/perf/perf_tools/startup_measurement.py View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
7 years, 6 months ago (2013-05-28 21:57:58 UTC) #1
ramant (doing other things)
7 years, 6 months ago (2013-05-28 21:58:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r202662.

Powered by Google App Engine
This is Rietveld 408576698