trunk/src/tools/perf/perf_tools/histogram_metric.py - Issue 16160006: Revert 202620 "Collect tab timing information for use in telemen..."

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: trunk/src/tools/perf/perf_tools/histogram_metric.py

Issue 16160006: Revert 202620 "Collect tab timing information for use in telemen..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « trunk/src/content/renderer/stats_collection_observer.cc ('k') | trunk/src/tools/perf/perf_tools/memory_measurement.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from perf_tools import histogram as histogram_module	4 from perf_tools import histogram as histogram_module

5	5

6 BROWSER_HISTOGRAM = 'browser_histogram'	6 BROWSER_HISTOGRAM = 'browser_histogram'

7 RENDERER_HISTOGRAM = 'renderer_histogram'	7 RENDERER_HISTOGRAM = 'renderer_histogram'

8	8

9 class HistogramMetric(object):	9 class HistogramMetric(object):

10 def __init__(self, histogram, histogram_type):	10 def __init__(self, histogram, histogram_type):

(...skipping 18 matching lines...) Expand all Loading...
29 results.Add(self.name, self.units, new_histogram,	29 results.Add(self.name, self.units, new_histogram,

30 data_type='unimportant-histogram')	30 data_type='unimportant-histogram')

31	31

32 @property	32 @property

33 def histogram_function(self):	33 def histogram_function(self):

34 if self.histogram_type == BROWSER_HISTOGRAM:	34 if self.histogram_type == BROWSER_HISTOGRAM:

35 return 'getBrowserHistogram'	35 return 'getBrowserHistogram'

36 return 'getHistogram'	36 return 'getHistogram'

37	37

38 def _GetHistogramFromDomAutomation(self, tab):	38 def _GetHistogramFromDomAutomation(self, tab):

39 js = ('window.statsCollectionController.%s ? '	39 js = ('window.domAutomationController.%s ? '

40 'window.statsCollectionController.%s("%s") : ""' %	40 'window.domAutomationController.%s("%s") : ""' %

41 (self.histogram_function, self.histogram_function, self.name))	41 (self.histogram_function, self.histogram_function, self.name))

42 return tab.EvaluateJavaScript(js)	42 return tab.EvaluateJavaScript(js)

OLD	NEW