Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Unified Diff: net/quic/crypto/channel_id_chromium.cc

Issue 1615943003: Remove unnecessary ERR_CHANNEL_ID_IMPORT_FAILED codepath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_error_list.h ('k') | net/socket/ssl_client_socket_openssl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/channel_id_chromium.cc
diff --git a/net/quic/crypto/channel_id_chromium.cc b/net/quic/crypto/channel_id_chromium.cc
index 3f50b768302f95565369a11816da0bef53620231..1aec7e7b8a0da2f782e4fb91cb1a7fb24840eaa7 100644
--- a/net/quic/crypto/channel_id_chromium.cc
+++ b/net/quic/crypto/channel_id_chromium.cc
@@ -190,14 +190,9 @@ int ChannelIDSourceChromium::Job::DoGetChannelIDKeyComplete(int result) {
return result;
}
- if (!channel_id_crypto_key_) {
- // TODO(wtc): use the new error code ERR_CHANNEL_ID_IMPORT_FAILED to be
- // added in https://codereview.chromium.org/338093012/.
- return ERR_UNEXPECTED;
- }
+ DCHECK(channel_id_crypto_key_);
channel_id_key_.reset(
new ChannelIDKeyChromium(std::move(channel_id_crypto_key_)));
-
return result;
}
« no previous file with comments | « net/base/net_error_list.h ('k') | net/socket/ssl_client_socket_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698