Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1615943003: Remove unnecessary ERR_CHANNEL_ID_IMPORT_FAILED codepath. (Closed)

Created:
4 years, 11 months ago by davidben
Modified:
4 years, 11 months ago
Reviewers:
nharper
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary ERR_CHANNEL_ID_IMPORT_FAILED codepath. This dates to https://codereview.chromium.org/338093012/, when the store returned a string rather than an ECPrivateKey. As of https://codereview.chromium.org/1076063002, the store returns an object so this codepath isn't possible. Remove it. BUG=none Committed: https://crrev.com/8a208fc52455fe0f2de4f7ad5e2a6d77ead4ab8b Cr-Commit-Position: refs/heads/master@{#370984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M net/base/net_error_list.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/crypto/channel_id_chromium.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
davidben
4 years, 11 months ago (2016-01-22 00:10:31 UTC) #2
nharper
lgtm
4 years, 11 months ago (2016-01-22 00:20:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615943003/1
4 years, 11 months ago (2016-01-22 00:26:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/168680)
4 years, 11 months ago (2016-01-22 01:46:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615943003/1
4 years, 11 months ago (2016-01-22 16:12:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 17:08:19 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 17:09:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a208fc52455fe0f2de4f7ad5e2a6d77ead4ab8b
Cr-Commit-Position: refs/heads/master@{#370984}

Powered by Google App Engine
This is Rietveld 408576698