third_party/WebKit/Source/core/fetch/ResourceFetcher.h - Issue 1615803004: Avoid double download for late discovered link preload resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

Issue 1615803004: Avoid double download for late discovered link preload resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Permit memcache removal when ResourceFetcher is destroyed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

index 2f5a2849a805912e2472570c5c9867700088c933..397c5a8fd781e4628a0418bd65824140bb0a28c1 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

@@ -93,8 +93,10 @@ public:

int requestCount() const;

+ enum ClearPreloadsType { ClearAllPreloads, ClearSpeculativeMarkupPreloads };

Nate Chapin 2016/01/21 19:07:14 ClearPreloadsPolicy?

Yoav Weiss 2016/01/21 20:34:09 yup

bool isPreloaded(const KURL&) const;

- void clearPreloads();

+ void clearPreloads(ClearPreloadsType = ClearAllPreloads);

Nate Chapin 2016/01/21 19:07:14 How many callsites are there for clearPreloads()?

Yoav Weiss 2016/01/21 20:34:09 Yeah, but the preFinalizer is taking this as a met

void preloadStarted(Resource*);

void printPreloadStats();