Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 1615803004: Avoid double download for late discovered link preload resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Permit memcache removal when ResourceFetcher is destroyed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index 58f0257ec8445b61639a30252021a7619c303f01..d800f84503b84e2158fcf8f32c448024dc40dc79 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -829,7 +829,7 @@ bool ResourceFetcher::isPreloaded(const KURL& url) const
return false;
}
-void ResourceFetcher::clearPreloads()
+void ResourceFetcher::clearPreloads(ClearPreloadsType type)
{
#if PRELOAD_DEBUG
printPreloadStats();
@@ -840,7 +840,7 @@ void ResourceFetcher::clearPreloads()
for (auto resource : *m_preloads) {
resource->decreasePreloadCount();
bool deleted = resource->deleteIfPossible();
- if (!deleted && resource->preloadResult() == Resource::PreloadNotReferenced)
+ if (!deleted && resource->preloadResult() == Resource::PreloadNotReferenced && (type == ClearAllPreloads || !resource->avoidBlockingOnLoad()))
Nate Chapin 2016/01/21 19:07:14 I assume avoidBlockingOnLoad() is checked because
Yoav Weiss 2016/01/21 20:34:09 added
memoryCache()->remove(resource.get());
}
m_preloads.clear();

Powered by Google App Engine
This is Rietveld 408576698